From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45974)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1a3kbG-0006QF-UT
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:04:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1a3kbB-0004CK-Cy
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:04:06 -0500
Received: from mx1.redhat.com ([209.132.183.28]:54088)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1a3kbB-0004CG-7f
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:04:01 -0500
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (Postfix) with ESMTPS id D5AFFC802
	for <qemu-devel@nongnu.org>; Tue,  1 Dec 2015 13:04:00 +0000 (UTC)
Date: Tue, 1 Dec 2015 21:03:45 +0800
From: Peter Xu <peterx@redhat.com>
Message-ID: <20151201130342.GC31109@pxdev.xzpeter.org>
References: <1448883140-20249-1-git-send-email-peterx@redhat.com>
	<1448883140-20249-11-git-send-email-peterx@redhat.com>
	<565C478A.8080106@redhat.com>
	<20151201035755.GI21032@pxdev.xzpeter.org>
	<565D6E68.1060303@redhat.com>
	<20151201123250.GA31109@pxdev.xzpeter.org>
	<565D9491.5000909@redhat.com>
	<20151201124545.GB31109@pxdev.xzpeter.org>
	<565D96CC.6020304@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <565D96CC.6020304@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 10/12] Dump: add qmp command "query-dump"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: drjones@redhat.com, lersek@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, famz@redhat.com, lcapitulino@redhat.com

On Tue, Dec 01, 2015 at 01:47:08PM +0100, Paolo Bonzini wrote:
> 
> 
> On 01/12/2015 13:45, Peter Xu wrote:
> >> > It's a matter of taste though.  What you wrote above is certainly okay
> >> > as well.
> > Thanks for the explanation. Then I will choose smp_*() this time and
> > post v4 later.
> 
> In that case, remember to add a comment before each smp_*(), similar to
> the one in thread-pool.c.

Ok.

Thanks.
Peter

> 
> Paolo