From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3nrX-00014W-Qe for qemu-devel@nongnu.org; Tue, 01 Dec 2015 11:33:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3nrU-0002L8-0q for qemu-devel@nongnu.org; Tue, 01 Dec 2015 11:33:07 -0500 Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:40522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3nrT-0002KR-Ri for qemu-devel@nongnu.org; Tue, 01 Dec 2015 11:33:03 -0500 Date: Tue, 1 Dec 2015 17:32:54 +0100 From: Aurelien Jarno Message-ID: <20151201163254.GB9577@aurel32.net> References: <1448986767-28016-1-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448986767-28016-1-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH for-2.5] tcg: Increase the highwater reservation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org On 2015-12-01 08:19, Richard Henderson wrote: > If there are a lot of guest memory ops in the TB, the amount of > code generated by tcg_out_tb_finalize could be well more than 1k. > In the short term, increase the reservation larger than any TB > seen in practice. > > Reported-by: Aurelien Jarno > Signed-off-by: Richard Henderson Thanks! I was testing the same patch locally after our discussion, and I confirm it fixes the issue. Reviewed-by: Aurelien Jarno Tested-by: Aurelien Jarno -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net