From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3vQV-0007cy-9b for qemu-devel@nongnu.org; Tue, 01 Dec 2015 19:37:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3vQR-0008BQ-VS for qemu-devel@nongnu.org; Tue, 01 Dec 2015 19:37:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:26744) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3vQR-0008B3-Qx for qemu-devel@nongnu.org; Tue, 01 Dec 2015 19:37:39 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id B77848E688 for ; Wed, 2 Dec 2015 00:37:38 +0000 (UTC) Date: Wed, 2 Dec 2015 08:37:36 +0800 From: Fam Zheng Message-ID: <20151202003736.GA9399@ad.usersys.redhat.com> References: <1448976530-15984-1-git-send-email-peterx@redhat.com> <1448976530-15984-2-git-send-email-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448976530-15984-2-git-send-email-peterx@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 01/11] dump-guest-memory: cleanup: removing dump_{error|cleanup}(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: drjones@redhat.com, lersek@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, lcapitulino@redhat.com On Tue, 12/01 21:28, Peter Xu wrote: > It might be a little bit confusing to do dump_cleanup() in these two > functions and error prone. A better way is to do dump_cleanup() I would say "It might be a little bit confusing and error prone to do dump_cleanup() in ..." Other than that, Reviewed-by: Fam Zheng > before dump finish, no matter whether dump has succeeded or not. > > Signed-off-by: Peter Xu