From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52991)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1a3vdD-0003Ao-7v
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 19:50:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1a3vdC-0002si-Hc
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 19:50:51 -0500
Received: from mx1.redhat.com ([209.132.183.28]:49657)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1a3vdC-0002sQ-62
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 19:50:50 -0500
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (Postfix) with ESMTPS id D5D838E74E
	for <qemu-devel@nongnu.org>; Wed,  2 Dec 2015 00:50:49 +0000 (UTC)
Date: Wed, 2 Dec 2015 08:50:48 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20151202005048.GD9399@ad.usersys.redhat.com>
References: <1448976530-15984-1-git-send-email-peterx@redhat.com>
	<1448976530-15984-7-git-send-email-peterx@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1448976530-15984-7-git-send-email-peterx@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 06/11] dump-guest-memory: disable dump
 when in INMIGRATE state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Xu <peterx@redhat.com>
Cc: drjones@redhat.com, lersek@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, lcapitulino@redhat.com

On Tue, 12/01 21:28, Peter Xu wrote:
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  dump.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/dump.c b/dump.c
> index e46749d..65d1f7e 100644
> --- a/dump.c
> +++ b/dump.c
> @@ -1626,13 +1626,17 @@ void qmp_dump_guest_memory(bool paging, const char *file,
>      DumpState *s;
>      Error *local_err = NULL;
>  
> +    if (runstate_check(RUN_STATE_INMIGRATE)) {
> +        error_setg(errp, "Dump not allowed during incoming migration.");
> +        return;
> +    }
> +
>      /* if there is a dump in background, we should wait until the dump
>       * finished */
>      if (dump_in_progress()) {
>          error_setg(errp, "There is a dump in process, please wait.");
>          return;
>      }
> -

Blank line change, please drop.

Fam

>      /*
>       * kdump-compressed format need the whole memory dumped, so paging or
>       * filter is not supported here.
> -- 
> 2.4.3
>