From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53257)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1a3xUl-0003EM-Ex
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 21:50:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1a3xUg-00028k-FR
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 21:50:15 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33686)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1a3xUg-00028Y-AN
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 21:50:10 -0500
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (Postfix) with ESMTPS id C4FCCC0CC62D
	for <qemu-devel@nongnu.org>; Wed,  2 Dec 2015 02:50:09 +0000 (UTC)
Date: Wed, 2 Dec 2015 10:50:00 +0800
From: Peter Xu <peterx@redhat.com>
Message-ID: <20151202025000.GB16647@pxdev.xzpeter.org>
References: <1448976530-15984-1-git-send-email-peterx@redhat.com>
	<1448976530-15984-2-git-send-email-peterx@redhat.com>
	<20151202003736.GA9399@ad.usersys.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20151202003736.GA9399@ad.usersys.redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 01/11] dump-guest-memory: cleanup:
 removing dump_{error|cleanup}().
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: drjones@redhat.com, lersek@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, lcapitulino@redhat.com

On Wed, Dec 02, 2015 at 08:37:36AM +0800, Fam Zheng wrote:
> On Tue, 12/01 21:28, Peter Xu wrote:
> > It might be a little bit confusing to do dump_cleanup() in these two
> > functions and error prone. A better way is to do dump_cleanup()
> 
> I would say "It might be a little bit confusing and error prone to do
> dump_cleanup() in ..."

Yes. Changing it.

Thanks.
Peter

> 
> Other than that,
> 
> Reviewed-by: Fam Zheng <famz@redhat.com>
> 
> > before dump finish, no matter whether dump has succeeded or not.
> > 
> > Signed-off-by: Peter Xu <peterx@redhat.com>