From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a40Ep-0004jm-T4 for qemu-devel@nongnu.org; Wed, 02 Dec 2015 00:46:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a40Em-00060X-Nd for qemu-devel@nongnu.org; Wed, 02 Dec 2015 00:45:59 -0500 Received: from e28smtp05.in.ibm.com ([122.248.162.5]:36737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a40El-00060I-VF for qemu-devel@nongnu.org; Wed, 02 Dec 2015 00:45:56 -0500 Received: from localhost by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 2 Dec 2015 11:15:52 +0530 Date: Wed, 2 Dec 2015 11:15:44 +0530 From: Bharata B Rao Message-ID: <20151202054544.GA21317@in.ibm.com> References: <1448024079-20808-1-git-send-email-bharata@linux.vnet.ibm.com> <1448024079-20808-7-git-send-email-bharata@linux.vnet.ibm.com> <20151201010136.GE31343@voom.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151201010136.GE31343@voom.redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 06/10] xics_kvm: Add cpu_destroy method to XICS Reply-To: bharata@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: mdroth@linux.vnet.ibm.com, aik@ozlabs.ru, agraf@suse.de, qemu-devel@nongnu.org, pbonzini@redhat.com, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, imammedo@redhat.com, afaerber@suse.de On Tue, Dec 01, 2015 at 12:01:36PM +1100, David Gibson wrote: > On Fri, Nov 20, 2015 at 06:24:35PM +0530, Bharata B Rao wrote: > > XICS is setup for each CPU during initialization. Provide a routine > > to undo the same when CPU is unplugged. > > > > This allows reboot of a VM that has undergone CPU hotplug and unplug > > to work correctly. > > > > Signed-off-by: Bharata B Rao > > Reviewed-by: David Gibson > > --- > > hw/intc/xics.c | 12 ++++++++++++ > > hw/intc/xics_kvm.c | 13 +++++++++++-- > > include/hw/ppc/xics.h | 2 ++ > > 3 files changed, 25 insertions(+), 2 deletions(-) > > > > diff --git a/hw/intc/xics.c b/hw/intc/xics.c > > index 9ff5796..e1161b2 100644 > > --- a/hw/intc/xics.c > > +++ b/hw/intc/xics.c > > @@ -44,6 +44,18 @@ static int get_cpu_index_by_dt_id(int cpu_dt_id) > > return -1; > > } > > > > +void xics_cpu_destroy(XICSState *icp, PowerPCCPU *cpu) > > +{ > > + CPUState *cs = CPU(cpu); > > + XICSStateClass *info = XICS_COMMON_GET_CLASS(icp); > > + > > + assert(cs->cpu_index < icp->nr_servers); > > + > > + if (info->cpu_destroy) { > > + info->cpu_destroy(icp, cpu); > > + } > > +} > > + > > void xics_cpu_setup(XICSState *icp, PowerPCCPU *cpu) > > { > > CPUState *cs = CPU(cpu); > > diff --git a/hw/intc/xics_kvm.c b/hw/intc/xics_kvm.c > > index d58729c..cb96f69 100644 > > --- a/hw/intc/xics_kvm.c > > +++ b/hw/intc/xics_kvm.c > > @@ -331,6 +331,8 @@ static void xics_kvm_cpu_setup(XICSState *icp, PowerPCCPU *cpu) > > abort(); > > } > > > > + ss->cs = cs; > > + > > Actually, it probably makes more sense to move the management of > ss->cs to the base xics code. There's nothing really kvm specific > about it. Right, let me try changing this in next iteration. Regards, Bharata.