From: Fam Zheng <famz@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: drjones@redhat.com, lersek@redhat.com, armbru@redhat.com,
qemu-devel@nongnu.org, pbonzini@redhat.com,
lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED
Date: Wed, 2 Dec 2015 17:57:16 +0800 [thread overview]
Message-ID: <20151202095716.GB21121@ad.usersys.redhat.com> (raw)
In-Reply-To: <20151202082022.GC19485@pxdev.xzpeter.org>
On Wed, 12/02 16:20, Peter Xu wrote:
> On Wed, Dec 02, 2015 at 09:11:31AM +0800, Fam Zheng wrote:
> > On Tue, 12/01 21:28, Peter Xu wrote:
> > > +
> > > +##
> > > +# @DUMP_COMPLETED
> > > +#
> > > +# Emitted when background dump has completed
> > > +#
> > > +# @error: #optional human-readable error string that provides
> > > +# hint on why dump failed.
> >
> > Please explicitly mention that successful dump emits DUMP_COMPLETED without
> > error, and failed dump emits DUMP_COMPLETED that has an error str.
>
> Ok. I can add more words to describe it. Maybe something like:
>
> # @error: #optional human-readable error string that provides
> # hint on why dump failed. Only presents on failure. The
> # user should not try to interpret the error string.
>
> How do you think about this one?
That looks ok.
next prev parent reply other threads:[~2015-12-02 9:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 13:28 [Qemu-devel] [PATCH v4 00/11] Add basic "detach" support for dump-guest-memory Peter Xu
2015-12-01 13:28 ` [Qemu-devel] [PATCH v4 01/11] dump-guest-memory: cleanup: removing dump_{error|cleanup}() Peter Xu
2015-12-02 0:37 ` Fam Zheng
2015-12-02 2:50 ` Peter Xu
2015-12-01 13:28 ` [Qemu-devel] [PATCH v4 02/11] dump-guest-memory: add "detach" flag for QMP/HMP interfaces Peter Xu
2015-12-01 13:28 ` [Qemu-devel] [PATCH v4 03/11] dump-guest-memory: using static DumpState, add DumpStatus Peter Xu
2015-12-02 0:46 ` Fam Zheng
2015-12-02 3:00 ` Peter Xu
2015-12-01 13:28 ` [Qemu-devel] [PATCH v4 04/11] dump-guest-memory: add dump_in_progress() helper function Peter Xu
2015-12-01 13:28 ` [Qemu-devel] [PATCH v4 05/11] dump-guest-memory: introduce dump_process() " Peter Xu
2015-12-02 0:50 ` Fam Zheng
2015-12-01 13:28 ` [Qemu-devel] [PATCH v4 06/11] dump-guest-memory: disable dump when in INMIGRATE state Peter Xu
2015-12-02 0:50 ` Fam Zheng
2015-12-02 6:50 ` Peter Xu
2015-12-01 13:28 ` [Qemu-devel] [PATCH v4 07/11] dump-guest-memory: add "detach" support Peter Xu
2015-12-01 13:28 ` [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED Peter Xu
2015-12-02 1:11 ` Fam Zheng
2015-12-02 8:20 ` Peter Xu
2015-12-02 9:57 ` Fam Zheng [this message]
2015-12-02 14:45 ` Eric Blake
2015-12-02 15:21 ` Peter Xu
2015-12-02 16:01 ` Eric Blake
2015-12-03 1:28 ` Peter Xu
2015-12-01 13:28 ` [Qemu-devel] [PATCH v4 09/11] DumpState: adding total_size and written_size fields Peter Xu
2015-12-02 1:32 ` Fam Zheng
2015-12-02 8:49 ` Peter Xu
2015-12-02 9:49 ` Fam Zheng
2015-12-02 10:41 ` Peter Xu
2015-12-02 12:51 ` Fam Zheng
2015-12-02 14:14 ` Peter Xu
2015-12-01 13:28 ` [Qemu-devel] [PATCH v4 10/11] Dump: add qmp command "query-dump" Peter Xu
2015-12-01 13:28 ` [Qemu-devel] [PATCH v4 11/11] Dump: add hmp command "info dump" Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151202095716.GB21121@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=armbru@redhat.com \
--cc=drjones@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).