From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43458)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1a44A8-0002Gb-Gp
	for qemu-devel@nongnu.org; Wed, 02 Dec 2015 04:57:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1a44A5-0006mK-BU
	for qemu-devel@nongnu.org; Wed, 02 Dec 2015 04:57:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:42355)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1a44A5-0006lz-6q
	for qemu-devel@nongnu.org; Wed, 02 Dec 2015 04:57:21 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (Postfix) with ESMTPS id 92813C4099
	for <qemu-devel@nongnu.org>; Wed,  2 Dec 2015 09:57:20 +0000 (UTC)
Date: Wed, 2 Dec 2015 17:57:16 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20151202095716.GB21121@ad.usersys.redhat.com>
References: <1448976530-15984-1-git-send-email-peterx@redhat.com>
	<1448976530-15984-9-git-send-email-peterx@redhat.com>
	<20151202011131.GE9399@ad.usersys.redhat.com>
	<20151202082022.GC19485@pxdev.xzpeter.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151202082022.GC19485@pxdev.xzpeter.org>
Subject: Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event
	DUMP_COMPLETED
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Xu <peterx@redhat.com>
Cc: drjones@redhat.com, lersek@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, lcapitulino@redhat.com

On Wed, 12/02 16:20, Peter Xu wrote:
> On Wed, Dec 02, 2015 at 09:11:31AM +0800, Fam Zheng wrote:
> > On Tue, 12/01 21:28, Peter Xu wrote:
> > > +
> > > +##
> > > +# @DUMP_COMPLETED
> > > +#
> > > +# Emitted when background dump has completed
> > > +#
> > > +# @error: #optional human-readable error string that provides
> > > +#         hint on why dump failed.
> > 
> > Please explicitly mention that successful dump emits DUMP_COMPLETED without
> > error, and failed dump emits DUMP_COMPLETED that has an error str.
> 
> Ok. I can add more words to describe it. Maybe something like:
> 
> # @error: #optional human-readable error string that provides
> #         hint on why dump failed. Only presents on failure. The
> #         user should not try to interpret the error string.
> 
> How do you think about this one?

That looks ok.