From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51797) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a48BL-0007Hp-IL for qemu-devel@nongnu.org; Wed, 02 Dec 2015 09:15:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a48BF-0004m0-MV for qemu-devel@nongnu.org; Wed, 02 Dec 2015 09:14:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a48BF-0004lw-HS for qemu-devel@nongnu.org; Wed, 02 Dec 2015 09:14:49 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 110F12651 for ; Wed, 2 Dec 2015 14:14:49 +0000 (UTC) Date: Wed, 2 Dec 2015 22:14:41 +0800 From: Peter Xu Message-ID: <20151202141440.GA18392@pxdev.xzpeter.org> References: <1448976530-15984-1-git-send-email-peterx@redhat.com> <1448976530-15984-10-git-send-email-peterx@redhat.com> <20151202013257.GF9399@ad.usersys.redhat.com> <20151202084919.GD19485@pxdev.xzpeter.org> <20151202094918.GA21121@ad.usersys.redhat.com> <20151202104153.GE19485@pxdev.xzpeter.org> <20151202125148.GA10157@ad.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20151202125148.GA10157@ad.usersys.redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 09/11] DumpState: adding total_size and written_size fields List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: drjones@redhat.com, lersek@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, lcapitulino@redhat.com On Wed, Dec 02, 2015 at 08:51:48PM +0800, Fam Zheng wrote: > On Wed, 12/02 18:41, Peter Xu wrote: > > On Wed, Dec 02, 2015 at 05:49:18PM +0800, Fam Zheng wrote: > > Label "out" is out of the loop. So, when error happens, it sets the > > errp and directly jump out of the loop. Did I miss anything? > > > > You are right, I misread the context of this incremental. Thanks. Thanks for review my first patch (even until v4 and more). :) Peter > > Fam