qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
	Jason Wang <jasowang@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [2.5 issue] virtio-1 in virtio-net and old vhost
Date: Wed, 2 Dec 2015 14:41:36 +0200	[thread overview]
Message-ID: <20151202144026-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <20151202111128.03f4f46d.cornelia.huck@de.ibm.com>

On Wed, Dec 02, 2015 at 11:11:28AM +0100, Cornelia Huck wrote:
> On Wed, 2 Dec 2015 13:54:09 +0800
> Jason Wang <jasowang@redhat.com> wrote:
> 
> > I wonder instead of rolling back in post_plugged(), maybe we could just
> > delay the region setups to post_plugged(). 
> 
> If this is the saner thing to do for pci, sure.
> 
> > Or just call transport
> > specific device_plugged() after get_features() call in
> > virtio_bus_device_plugged(). 
> 
> The problem is that the VERSION_1 bit is only added in the
> ->device_plugged() callbacks by the transport, so ->get_features() can
> only be called after that. We have a dependency in both directions :(
> 
> > And I'm not sure we need to handle
> > migration compatibility in this case.
> 
> The thing we would need to care about is basically the host kernel on
> the target supporting less than the host kernel on the source.

This is a fundamental problem, we have it with other
features like transport offloads. We don't have a solution for
this now. kvm has the same issue.

> Do we
> care about that in other contexts right now?

  reply	other threads:[~2015-12-02 12:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-01 10:11 [Qemu-devel] [2.5 issue] virtio-1 in virtio-net and old vhost Cornelia Huck
2015-12-01 12:10 ` Cornelia Huck
2015-12-01 14:21   ` Cornelia Huck
2015-12-02  5:54     ` Jason Wang
2015-12-02 10:11       ` Cornelia Huck
2015-12-02 12:41         ` Michael S. Tsirkin [this message]
2015-12-04  2:06         ` Jason Wang
2015-12-04 10:15           ` Cornelia Huck
2015-12-04 13:36             ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151202144026-mutt-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).