From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33495)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1a4B6e-0007cD-1m
	for qemu-devel@nongnu.org; Wed, 02 Dec 2015 12:22:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1a4B6a-0002TG-J9
	for qemu-devel@nongnu.org; Wed, 02 Dec 2015 12:22:16 -0500
Received: from mx1.redhat.com ([209.132.183.28]:49071)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1a4B6a-0002TC-DV
	for qemu-devel@nongnu.org; Wed, 02 Dec 2015 12:22:12 -0500
Date: Wed, 2 Dec 2015 19:22:08 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20151202192147-mutt-send-email-mst@redhat.com>
References: <1449066801-3002-1-git-send-email-shmulik.ladkani@ravellosystems.com>
	<565F0A20.8050507@redhat.com>
	<20151202184610-mutt-send-email-mst@redhat.com>
	<20151202191247.7326c7a3@halley>
	<20151202191841-mutt-send-email-mst@redhat.com>
	<565F2890.5080801@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <565F2890.5080801@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 for-2.5] virtio-pci: Set the
 QEMU_PCI_CAP_EXPRESS capability early in its DeviceClass realize method
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcel Apfelbaum <marcel@redhat.com>
Cc: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>, qemu-devel@nongnu.org

On Wed, Dec 02, 2015 at 07:21:20PM +0200, Marcel Apfelbaum wrote:
> On 12/02/2015 07:19 PM, Michael S. Tsirkin wrote:
> >On Wed, Dec 02, 2015 at 07:12:47PM +0200, Shmulik Ladkani wrote:
> >>Hi Michael,
> >>
> >>On Wed, 2 Dec 2015 18:49:24 +0200 "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >>>On Wed, Dec 02, 2015 at 05:11:28PM +0200, Marcel Apfelbaum wrote:
> >>>>The only thing I want to mention here, (see earlier discussion: https://www.mail-archive.com/qemu-devel@nongnu.org/msg338963.html)
> >>>>is that in some cases the PCI config space will have PCIe length, even if the device is not express.
> >>>>
> >>>>To be more precise, the only interesting scenario is when we plug a virtio device directly into
> >>>>the root complex, in this case we'll have a PCI device with a PCIe config space.
> >>>>
> >>>>However this happens for other devices as well, it looks like a common practice.
> >>>
> >>>Problem is, if this happens migration breaks as we
> >>>changed config space size from 2.4.
> >>
> >>Correct me if wrong, but as long as a pre 2.5 hardware is used, Marcel's
> >>x-disable-pcie gets on (see HW_COMPAT_2_4), thus the device will not be
> >>a "pci_is_express", and it will have a small config space size. Isn't it
> >>so?
> >>
> >>Regards,
> >>Shmulik
> >
> >OK. Still, I do not want to migrate 4k of config space
> >for pci devices.
> >
> 
> Shmulik, will you resend the patch with this minor change, or you prefer me to do it? 2.5 closes soon.
> 
> Thanks,
> Marcel

Soon is not the right word. Closing in 10.. 9.. 8..