From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44052) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4BYN-00018E-A5 for qemu-devel@nongnu.org; Wed, 02 Dec 2015 12:50:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4BYI-0004Xj-Rt for qemu-devel@nongnu.org; Wed, 02 Dec 2015 12:50:55 -0500 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:37681) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4BYI-0004Xd-Lp for qemu-devel@nongnu.org; Wed, 02 Dec 2015 12:50:50 -0500 Received: by wmww144 with SMTP id w144so67497978wmw.0 for ; Wed, 02 Dec 2015 09:50:50 -0800 (PST) Date: Wed, 2 Dec 2015 19:50:46 +0200 From: Shmulik Ladkani Message-ID: <20151202195046.01ac91f8@halley> In-Reply-To: <565F2890.5080801@redhat.com> References: <1449066801-3002-1-git-send-email-shmulik.ladkani@ravellosystems.com> <565F0A20.8050507@redhat.com> <20151202184610-mutt-send-email-mst@redhat.com> <20151202191247.7326c7a3@halley> <20151202191841-mutt-send-email-mst@redhat.com> <565F2890.5080801@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 for-2.5] virtio-pci: Set the QEMU_PCI_CAP_EXPRESS capability early in its DeviceClass realize method List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org Hi, On Wed, 2 Dec 2015 19:21:20 +0200 Marcel Apfelbaum wrote: > Shmulik, will you resend the patch with this minor change, or you prefer me > to do it? 2.5 closes soon. Sent a v3 with Michael's addition. Havn't had time to runtime test the new "else" part: meaning, if the virtio pci device is NOT on a pcie bus. Appreciate if you can take this. Regards, Shmulik