From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58823)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1a4doj-0001fj-4e
	for qemu-devel@nongnu.org; Thu, 03 Dec 2015 19:01:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1a4doh-0000jt-VV
	for qemu-devel@nongnu.org; Thu, 03 Dec 2015 19:01:41 -0500
Date: Fri, 4 Dec 2015 10:42:34 +1100
From: David Gibson <david@gibson.dropbear.id.au>
Message-ID: <20151203234234.GA9559@voom.redhat.com>
References: <878u5bzk6m.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="XsQoSWH+UP9D9v3l"
Content-Disposition: inline
In-Reply-To: <878u5bzk6m.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] -device spapr-dr-connector crashes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de


--XsQoSWH+UP9D9v3l
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 03, 2015 at 03:22:09PM +0100, Markus Armbruster wrote:
> Watch this:
>=20
>     $ qemu-system-ppc64 -nodefaults -S -display none -device spapr-dr-con=
nector
>     **
>     ERROR:/home/armbru/work/qemu/hw/ppc/spapr_drc.c:45:get_type_shift: as=
sertion failed: (is_power_of_2(type))
>     Aborted (core dumped)
>=20
> It may not make sense, but it shouldn't crash.  Should this device be
> available with -device / device_add?

No, it shouldn't.

In fact, I'm not sure it makes sense for these to be standalone QOM
objects at all - I haven't looked into the details enough, but I
suspect this would make more sense as a QOM interface on existing
devices.

>=20
> For what it's worth, help works:
>=20
>     $ qemu-system-ppc64 -nodefaults -S -display none -device spapr-dr-con=
nector,help
>     spapr-dr-connector.indicator-state=3Duint32
>     spapr-dr-connector.name=3Dstring
>     spapr-dr-connector.id=3Duint32
>     spapr-dr-connector.entity-sense=3Duint32
>     spapr-dr-connector.isolation-state=3Duint32
>     spapr-dr-connector.allocation-state=3Duint32
>     spapr-dr-connector.index=3Duint32
>     spapr-dr-connector.connector_type=3Duint32
>     spapr-dr-connector.fdt=3Dstruct
>=20

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--XsQoSWH+UP9D9v3l
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJWYNNqAAoJEGw4ysog2bOSPyMQALt1ibsavz8xKZSIJZUEYYRW
HQDSlka8CSymOd4ZsVfPSf3B1YSDZPQA60FdgNpMP99WxpEMIej+4htZX3gAeEAy
q1czHpt8fj8QEO32keAuBygFAA6xxJyJ8N+9w2oGZEzHNWET77dgoy+7rGicD8qa
A0HCg1OV0D/rLEbq7Y0tIIn+blaQPhLeQx2bna+WEknYiSVaVC/LKCiZh8/dAspy
a1v4i8xrqpL8bVj8kyb80j2ig1CaFc4w3eqkaxAT3mh70Jhj1n5PkY5UzfdwBTnL
bDy1uqc+HPO68wVPcQECevNhVzOd/39e/vjWxG4gJnD1rbxzr524OohCCRKXp/MZ
jpgex2oDdHW8iAZuWT0jufyeOjuTq2W4OCatVCmT8biVOmphgXp/lqNbhNiZWqRC
OMQTTFm9vPDfvVuli7/+oAtydy3VDokvPgzyyZugiih8/yVQh7YTGmOvwblqD2+f
6Sdc6n22B4Uj1NI6e5RWDt+0nV3GOAFx3KawM2xco4rVEbppFonIT02TPHfXBlvi
EE6clmBzXGTBCFaI2Jak5Hcts7jf1dTqKNag4pGJAZSRpYXRz/SM2zEYRt3SnqXd
cVjrJtfR1Sj5VjwBOZVPurx8LLJa3xLs+RCQF92+G6t6sGTVAClwoJkmjUrrOiUT
/KYmBtFBuGesZGJMiLSG
=Ue6u
-----END PGP SIGNATURE-----

--XsQoSWH+UP9D9v3l--