From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4dok-0001hQ-Du for qemu-devel@nongnu.org; Thu, 03 Dec 2015 19:01:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4doj-0000ka-Ab for qemu-devel@nongnu.org; Thu, 03 Dec 2015 19:01:42 -0500 Date: Fri, 4 Dec 2015 11:01:57 +1100 From: David Gibson Message-ID: <20151204000157.GF9559@voom.redhat.com> References: <87bna7v9bc.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XStn23h1fwudRqtG" Content-Disposition: inline In-Reply-To: <87bna7v9bc.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] Posible regressions around spapr-dr-connector property drc-connector[] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de --XStn23h1fwudRqtG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 03, 2015 at 04:30:31PM +0100, Markus Armbruster wrote: > 1. Before commit 94649d4 "spapr: Don't use QOM [*] syntax for DR > connectors", the indexes were small integers: >=20 > (qemu) info qom-tree > /machine (pseries-2.4-machine) > /unattached (container) > [...] > /device[5] (spapr-pci-host-bridge) > /pci@800000020000000.mmio[0] (qemu:memory-region) > /pci@800000020000000.mmio-alias[0] (qemu:memory-region) > /pci@800000020000000.io[0] (qemu:memory-region) > /pci@800000020000000.io-alias[0] (qemu:memory-region) > /pci.0 (PCI) > /pci@800000020000000.iommu-root[0] (qemu:memory-region) > /dr-connector[0] (spapr-dr-connector) > /dr-connector[1] (spapr-dr-connector) > /dr-connector[2] (spapr-dr-connector) > [...] >=20 > Since then, they're big ones: >=20 > /dr-connector[1073741824] (spapr-dr-connector) > /dr-connector[1073741825] (spapr-dr-connector) > /dr-connector[1073741826] (spapr-dr-connector) >=20 > The commit message doesn't quite spell out this change, and I'm > therefore double-checkint it's intentional. Is it? Yes, it's intentional. The small integers were arbitrarily allocated by the QOM magic [*] code, whereas the big integers are actually meaningful values (essentially the DRC's global ID for the dynamic reconfiguration hypervisor interfaces). > 2. Before commit 6c2f9a1 "qapi: Make output visitor return qnull() > instead of NULL", qom-get returned {}: >=20 > Since then, it returns null: >=20 > QMP> { "execute": "qom-get", "arguments": { "path": "/machine/unat= tached/device[5]/dr-connector[1073741950]", "property": "fdt" } } > {"return": null} >=20 > Does anyone care? Hm, I'm guessing this is a case where fdt is NULL internally. Which I think will happen before a device gets hotplugged into the DRC. In that case null seems more correct to me than {}, since {} would also be what's shown for a present-but-empty device tree. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --XStn23h1fwudRqtG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWYNf1AAoJEGw4ysog2bOSHX8P/iWzhdGKhZiSbFpGHYNr2OGd PdZVP73UFJyLMcXPL3gMZyC3pS38bEqc6FOuwW4oiyuZo+sBAHCVxh3/hLRsOyKE 4KjpPlADPHGFhARdurqMKTqvAbs+8zOHzulDIpNgaauS1S8iVL2txL7zQ1pAioEu COKm7oswbNs+LbNGHUBDc9wQqHgkaYv4//BTDF/J6LQ2syRqIkCo+fuHY63pHzcO hEn6DhSP8Xj/iZ+8bWvTYAlgcEUTVJsye0WnnrCwYKYAABgu31/ptOGbwGCCQTpX iqEM5YyQlb8Wg26JugOrW8KXuwNBXDjrR/A6vmidHz7DDosnA+xnSEMIG5fvLmsb bMX0Q5ppmzEFjdufvhst0ElrIYYA9SnBL0WrLJDSX90IWloEYSGNW5NXS0M8wyBH 2iBttk4//5SMartahgCbCxhYoKIqfPWH3tkqNG8BxzLzuMCJ2gth+wkwyw4BRmaG xjg7JX8Q/XSkFQ2ZluTHEy5kEMTmEt4wpqg+AE+ke0ZaP5zHgsYICulbDDsXNTun SaR5NpZLZQkRs3gYwkuhYXtJFQo2+eO74BfrAQEhHlwVWSHr4e1eVCBlnztfS0z8 hj47jiRxAlyfS9pPTrs49K0UD7NWwYbii8LH6Nh8Hvzb9WaSJjiLd/9sQdJ6m7wO mhXu+3r4Efq1VuNGleWV =rfp0 -----END PGP SIGNATURE----- --XStn23h1fwudRqtG--