From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4pnS-0003fb-G8 for qemu-devel@nongnu.org; Fri, 04 Dec 2015 07:49:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4pnN-0001o8-Dw for qemu-devel@nongnu.org; Fri, 04 Dec 2015 07:49:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4pnN-0001o2-8g for qemu-devel@nongnu.org; Fri, 04 Dec 2015 07:49:05 -0500 Date: Fri, 4 Dec 2015 18:18:42 +0530 From: Amit Shah Message-ID: <20151204124842.GD16990@grmbl.mre> References: <1449201190-22825-1-git-send-email-liang.z.li@intel.com> <1449201190-22825-2-git-send-email-liang.z.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449201190-22825-2-git-send-email-liang.z.li@intel.com> Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-file: fix flaws of qemu_put_compression_data List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liang Li Cc: qemu-devel@nongnu.org, dgilbert@redhat.com, quintela@redhat.com On (Fri) 04 Dec 2015 [11:53:09], Liang Li wrote: > There are some flaws in qemu_put_compression_data, this patch tries > to fix it. Now it can be used by other code. Can you please write a better description here? What are the flaws? What is being fixed? What other users, and how is it now safer for the other users to use this code? Thanks, Amit