From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [2.5 issue] virtio-1 in virtio-net and old vhost
Date: Fri, 4 Dec 2015 15:36:43 +0200 [thread overview]
Message-ID: <20151204153550-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <20151204111548.155ea5f7.cornelia.huck@de.ibm.com>
On Fri, Dec 04, 2015 at 11:15:48AM +0100, Cornelia Huck wrote:
> On Fri, 4 Dec 2015 10:06:58 +0800
> Jason Wang <jasowang@redhat.com> wrote:
>
> > The problem is for pci: without this patch, guest may always see modern
> > bar is "disable-modern=false". But with this patch, on an old kernel
> > that does not support VERSION_1, even "disable-modern=false" were
> > specified, guest can not see modern bar anymore. Looks like a guest
> > visible change.
>
> But the guest even see a modern bar if the host is not able to present
> a spec-compliant device?
>
> What we have now is a device that looks like a modern device but that
> does not offer VERSION_1. Probably not spec compliant. If virtio-pci is
> fixed to not present such broken devices to the guest, this is
> guest-visible, yes; but only in the sense that the guest will no longer
> see broken devices, but simply legacy devices if configured.
I agree - we don't have to keep what's broken, broken.
If guests are known not to work, we don't worry about
how well they migrate.
--
MST
prev parent reply other threads:[~2015-12-04 13:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 10:11 [Qemu-devel] [2.5 issue] virtio-1 in virtio-net and old vhost Cornelia Huck
2015-12-01 12:10 ` Cornelia Huck
2015-12-01 14:21 ` Cornelia Huck
2015-12-02 5:54 ` Jason Wang
2015-12-02 10:11 ` Cornelia Huck
2015-12-02 12:41 ` Michael S. Tsirkin
2015-12-04 2:06 ` Jason Wang
2015-12-04 10:15 ` Cornelia Huck
2015-12-04 13:36 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204153550-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).