From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44084)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shmulik.ladkani@ravellosystems.com>)
	id 1a4wBK-0002Xq-Cq
	for qemu-devel@nongnu.org; Fri, 04 Dec 2015 14:38:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <shmulik.ladkani@ravellosystems.com>)
	id 1a4wBF-0005aW-CW
	for qemu-devel@nongnu.org; Fri, 04 Dec 2015 14:38:14 -0500
Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:32987)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shmulik.ladkani@ravellosystems.com>)
	id 1a4wBF-0005a9-5u
	for qemu-devel@nongnu.org; Fri, 04 Dec 2015 14:38:09 -0500
Received: by wmec201 with SMTP id c201so88949905wme.0
	for <qemu-devel@nongnu.org>; Fri, 04 Dec 2015 11:38:08 -0800 (PST)
Date: Fri, 4 Dec 2015 21:38:02 +0200
From: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
Message-ID: <20151204213802.6be55871@halley>
In-Reply-To: <56615393.6020703@redhat.com>
References: <1449069991-6109-1-git-send-email-shmulik.ladkani@ravellosystems.com>
	<1449069991-6109-2-git-send-email-shmulik.ladkani@ravellosystems.com>
	<56615393.6020703@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/5] vmxnet3: Change offsets of msi/msix
 pci capabilities
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jason Wang <jasowang@redhat.com>
Cc: Dmitry Fleytman <dmitry@daynix.com>, Marcel Apfelbaum <marcel@redhat.com>, idan.brown@ravellosystems.com, qemu-devel@nongnu.org

Thanks Jason,

On Fri, 4 Dec 2015 16:49:23 +0800 Jason Wang <jasowang@redhat.com> wrote:
> > @@ -18,6 +18,10 @@
> >              .driver   = "virtio-pci",\
> >              .property = "migrate-extra",\
> >              .value    = "off",\
> > +        },{\
> > +            .driver   = "vmxnet3",\
> > +            .property = "x-old-msi-offsets",\
> > +            .value    = "on",\
> >          },
> 
> To have a better bisection behavior, we'd better enable this and compat
> it in patch 2.

Did you mean the following:

#1 Introduce the new functionality with its 'x-old-msi-offsets'
   property, with the property set to true by default

#2 Change 'x-old-msi-offsets' default value to false, and introduce the
   above compat

Regards,
Shmulik