Re: [Qemu-devel] [PATCH v5 06/11] dump-guest-memory: disable dump when in INMIGRATE state

[Fam Zheng <famz@redhat.com>]

On Mon, 12/07 13:56, Peter Xu wrote:
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  dump.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/dump.c b/dump.c
> index f0ee9a8..aa9d1f8 100644
> --- a/dump.c
> +++ b/dump.c
> @@ -1625,6 +1625,11 @@ void qmp_dump_guest_memory(bool paging, const char *file,
>      DumpState *s;
>      Error *local_err = NULL;
>  
> +    if (runstate_check(RUN_STATE_INMIGRATE)) {
> +        error_setg(errp, "Dump not allowed during incoming migration.");
> +        return;
> +    }
> +

Detached dump when "inmigrate" is disabled, that's OK.  But what about sync
dump? It used to be possible, but now is disabled. Just asking to make sure
this is the intention rather than oversight.

Fam

>      /* if there is a dump in background, we should wait until the dump
>       * finished */
>      if (dump_in_progress()) {
> -- 
> 2.4.3
>