From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5p3z-0004cu-6D for qemu-devel@nongnu.org; Mon, 07 Dec 2015 01:14:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a5p3v-0001Wb-5r for qemu-devel@nongnu.org; Mon, 07 Dec 2015 01:14:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44980) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5p3v-0001WW-10 for qemu-devel@nongnu.org; Mon, 07 Dec 2015 01:14:15 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 092DBC0B0229 for ; Mon, 7 Dec 2015 06:14:14 +0000 (UTC) Date: Mon, 7 Dec 2015 14:14:11 +0800 From: Fam Zheng Message-ID: <20151207061411.GC32154@ad.usersys.redhat.com> References: <1449467796-15856-1-git-send-email-peterx@redhat.com> <1449467796-15856-7-git-send-email-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449467796-15856-7-git-send-email-peterx@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 06/11] dump-guest-memory: disable dump when in INMIGRATE state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: drjones@redhat.com, lersek@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, lcapitulino@redhat.com On Mon, 12/07 13:56, Peter Xu wrote: > Signed-off-by: Peter Xu > --- > dump.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/dump.c b/dump.c > index f0ee9a8..aa9d1f8 100644 > --- a/dump.c > +++ b/dump.c > @@ -1625,6 +1625,11 @@ void qmp_dump_guest_memory(bool paging, const char *file, > DumpState *s; > Error *local_err = NULL; > > + if (runstate_check(RUN_STATE_INMIGRATE)) { > + error_setg(errp, "Dump not allowed during incoming migration."); > + return; > + } > + Detached dump when "inmigrate" is disabled, that's OK. But what about sync dump? It used to be possible, but now is disabled. Just asking to make sure this is the intention rather than oversight. Fam > /* if there is a dump in background, we should wait until the dump > * finished */ > if (dump_in_progress()) { > -- > 2.4.3 >