From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5po1-0003sj-1a for qemu-devel@nongnu.org; Mon, 07 Dec 2015 02:01:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a5pnw-0003PQ-2c for qemu-devel@nongnu.org; Mon, 07 Dec 2015 02:01:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51561) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5pnv-0003P9-UR for qemu-devel@nongnu.org; Mon, 07 Dec 2015 02:01:48 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id EE3595D for ; Mon, 7 Dec 2015 07:01:46 +0000 (UTC) Date: Mon, 7 Dec 2015 15:01:30 +0800 From: Peter Xu Message-ID: <20151207070130.GB2776@pxdev.xzpeter.org> References: <1449467796-15856-1-git-send-email-peterx@redhat.com> <1449467796-15856-7-git-send-email-peterx@redhat.com> <20151207061411.GC32154@ad.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20151207061411.GC32154@ad.usersys.redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 06/11] dump-guest-memory: disable dump when in INMIGRATE state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: drjones@redhat.com, lersek@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, lcapitulino@redhat.com On Mon, Dec 07, 2015 at 02:14:11PM +0800, Fam Zheng wrote: > On Mon, 12/07 13:56, Peter Xu wrote: > > + if (runstate_check(RUN_STATE_INMIGRATE)) { > > + error_setg(errp, "Dump not allowed during incoming migration."); > > + return; > > + } > > + > > Detached dump when "inmigrate" is disabled, that's OK. But what about sync > dump? It used to be possible, but now is disabled. Just asking to make sure > this is the intention rather than oversight. That's my intention here. This should be an idea from one of Paolo's review comment (forgot which one) and I hope I did not miss anything. I took this since I failed to find a use case that user might dump guest memory during incoming migration. Thanks. Peter > > Fam