From: Stefan Hajnoczi <stefanha@gmail.com>
To: Liang Li <liang.z.li@intel.com>
Cc: quintela@redhat.com, mit.shah@redhat.com, qemu-devel@nongnu.org,
dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-file: fix flaws of qemu_put_compression_data
Date: Mon, 7 Dec 2015 15:09:06 +0800 [thread overview]
Message-ID: <20151207070906.GA2515@stefanha-x1.localdomain> (raw)
In-Reply-To: <1449201128-22779-2-git-send-email-liang.z.li@intel.com>
[-- Attachment #1: Type: text/plain, Size: 454 bytes --]
On Fri, Dec 04, 2015 at 11:52:07AM +0800, Liang Li wrote:
> There are some flaws in qemu_put_compression_data, this patch tries
> to fix it. Now it can be used by other code.
This commit description is vague and doesn't explain what this patch
does or why it is necessary.
Please try to cover "what" and "why" instead of just saying that the
patch fixes flaws. If there are multiple points then maybe it should be
split into multiple patches.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-12-07 7:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 3:52 [Qemu-devel] [PATCH 0/2] fix the flaws of qemu_put_compression_data Liang Li
2015-12-04 3:52 ` [Qemu-devel] [PATCH 1/2] qemu-file: fix " Liang Li
2015-12-04 11:07 ` Juan Quintela
2015-12-04 14:25 ` Li, Liang Z
2015-12-04 19:44 ` Juan Quintela
2015-12-06 14:29 ` Li, Liang Z
2015-12-07 7:09 ` Stefan Hajnoczi [this message]
2015-12-07 7:09 ` Stefan Hajnoczi
2015-12-07 7:12 ` Li, Liang Z
2015-12-04 3:52 ` [Qemu-devel] [PATCH 2/2] migration: code clean up Liang Li
2015-12-04 11:02 ` [Qemu-devel] [PATCH 0/2] fix the flaws of qemu_put_compression_data Juan Quintela
2015-12-04 13:36 ` Li, Liang Z
-- strict thread matches above, loose matches on Subject: below --
2015-12-04 3:53 Liang Li
2015-12-04 3:53 ` [Qemu-devel] [PATCH 1/2] qemu-file: fix " Liang Li
2015-12-04 12:48 ` Amit Shah
2015-12-04 14:29 ` Li, Liang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151207070906.GA2515@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=dgilbert@redhat.com \
--cc=liang.z.li@intel.com \
--cc=mit.shah@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).