From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5tzU-0000hV-ND for qemu-devel@nongnu.org; Mon, 07 Dec 2015 06:30:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a5tzQ-00048S-Jp for qemu-devel@nongnu.org; Mon, 07 Dec 2015 06:30:00 -0500 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:37139) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5tzQ-000486-9a for qemu-devel@nongnu.org; Mon, 07 Dec 2015 06:29:56 -0500 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 7 Dec 2015 11:29:54 -0000 Date: Mon, 7 Dec 2015 12:29:49 +0100 From: Cornelia Huck Message-ID: <20151207122949.72abc5ce.cornelia.huck@de.ibm.com> In-Reply-To: <1449485967-19240-1-git-send-email-famz@redhat.com> References: <1449485967-19240-1-git-send-email-famz@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio-blk: Drop x-data-plane option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , pbonzini@redhat.com, Stefan Hajnoczi , qemu-devel@nongnu.org, qemu-block@nongnu.org On Mon, 7 Dec 2015 18:59:27 +0800 Fam Zheng wrote: > The official way of enabling dataplane is through the "iothread" > property that references an iothread object created by "-object > iothread". Since the old "x-data-plane=on" way now even crashes, it's > probably easier to just drop it: > > $ qemu-system-x86_64 -drive file=null-co://,id=d0,if=none \ > -device virtio-blk-pci,drive=d0,x-data-plane=on > > ERROR:/home/fam/work/qemu/qom/object.c:1515: > object_get_canonical_path_component: assertion failed: (obj->parent != NULL) > Aborted Do we understand yet why this crashes, btw? > > Signed-off-by: Fam Zheng > --- > hw/block/dataplane/virtio-blk.c | 15 ++------------- > hw/block/virtio-blk.c | 1 - > include/hw/virtio/virtio-blk.h | 1 - > 3 files changed, 2 insertions(+), 15 deletions(-) > No general objection to removing x-data-plane; but this probably wants a mention on the changelog as x-data-plane has been described in various howtos etc. over the years.