From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5y4w-0008OL-8w for qemu-devel@nongnu.org; Mon, 07 Dec 2015 10:51:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a5y4r-0005Ce-78 for qemu-devel@nongnu.org; Mon, 07 Dec 2015 10:51:54 -0500 Received: from e06smtp09.uk.ibm.com ([195.75.94.105]:37063) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5y4q-0005CF-Tt for qemu-devel@nongnu.org; Mon, 07 Dec 2015 10:51:49 -0500 Received: from localhost by e06smtp09.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 7 Dec 2015 15:51:47 -0000 Date: Mon, 7 Dec 2015 16:51:42 +0100 From: Cornelia Huck Message-ID: <20151207165142.45a14927.cornelia.huck@de.ibm.com> In-Reply-To: <5665A36B.1060502@redhat.com> References: <1449485967-19240-1-git-send-email-famz@redhat.com> <20151207122949.72abc5ce.cornelia.huck@de.ibm.com> <20151207130240.GH32154@ad.usersys.redhat.com> <5665A36B.1060502@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio-blk: Drop x-data-plane option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Kevin Wolf , Peter Maydell , Fam Zheng , qemu-block@nongnu.org, qemu-devel@nongnu.org, Stefan Hajnoczi On Mon, 7 Dec 2015 16:19:07 +0100 Paolo Bonzini wrote: > The solution would be to add object_property_add_child to > virtio_blk_data_plane_create, between object_initialize and > user_creatable_complete. But I think this patch is ok for 2.5. Just sent a patch that does this. If it is correct, I'd prefer it over either removing x-data-plane or reverting the iothread patch.