From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5ydY-0004zj-80 for qemu-devel@nongnu.org; Mon, 07 Dec 2015 11:27:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a5ydU-0003Hk-Uq for qemu-devel@nongnu.org; Mon, 07 Dec 2015 11:27:40 -0500 Received: from e06smtp05.uk.ibm.com ([195.75.94.101]:46949) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5ydU-0003HT-Ky for qemu-devel@nongnu.org; Mon, 07 Dec 2015 11:27:36 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 7 Dec 2015 16:27:34 -0000 Date: Mon, 7 Dec 2015 17:27:30 +0100 From: Cornelia Huck Message-ID: <20151207172730.719f8d65.cornelia.huck@de.ibm.com> In-Reply-To: <1449503401-19414-1-git-send-email-cornelia.huck@de.ibm.com> References: <1449503401-19414-1-git-send-email-cornelia.huck@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.5] virtio-blk/dataplane: parentize compat iothread List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, famz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com On Mon, 7 Dec 2015 16:50:01 +0100 Cornelia Huck wrote: > For x-data-plane=true, we create an iothread automatically for > compatibility. Commit d21e877 ("iothread: include id in thread name") > exposed that this iothread missed correct parenthood: fix this. > > Signed-off-by: Cornelia Huck > --- > hw/block/dataplane/virtio-blk.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c > index c42ddeb..c7e5668 100644 > --- a/hw/block/dataplane/virtio-blk.c > +++ b/hw/block/dataplane/virtio-blk.c > @@ -187,6 +187,9 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *conf, > object_initialize(&s->internal_iothread_obj, > sizeof(s->internal_iothread_obj), > TYPE_IOTHREAD); > + object_property_add_child(OBJECT(conf), TYPE_IOTHREAD, > + OBJECT(&s->internal_iothread_obj), > + &error_abort); > user_creatable_complete(OBJECT(&s->internal_iothread_obj), &error_abort); > s->iothread = &s->internal_iothread_obj; > } Scratch that, does not work... (I thought I was hitting the other segfault in the block backend processing...)