From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57287)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1a5ywD-0006ua-Sm
	for qemu-devel@nongnu.org; Mon, 07 Dec 2015 11:46:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1a5yw9-0001Pf-La
	for qemu-devel@nongnu.org; Mon, 07 Dec 2015 11:46:57 -0500
Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:60533)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1a5yw9-0001PY-7o
	for qemu-devel@nongnu.org; Mon, 07 Dec 2015 11:46:53 -0500
Received: from localhost
	by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <cornelia.huck@de.ibm.com>;
	Mon, 7 Dec 2015 16:46:52 -0000
Date: Mon, 7 Dec 2015 17:46:47 +0100
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Message-ID: <20151207174647.33a9b1d4.cornelia.huck@de.ibm.com>
In-Reply-To: <CAFEAcA-6U4ho0+H8do+BPUB_X5r3FcoA5jQNS1F3a7WkYsegLA@mail.gmail.com>
References: <1449503401-19414-1-git-send-email-cornelia.huck@de.ibm.com>
	<20151207172730.719f8d65.cornelia.huck@de.ibm.com>
	<CAFEAcA-6U4ho0+H8do+BPUB_X5r3FcoA5jQNS1F3a7WkYsegLA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.5] virtio-blk/dataplane: parentize
 compat iothread
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, Qemu-block <qemu-block@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On Mon, 7 Dec 2015 16:33:11 +0000
Peter Maydell <peter.maydell@linaro.org> wrote:

> On 7 December 2015 at 16:27, Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
> > On Mon,  7 Dec 2015 16:50:01 +0100
> > Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
> >
> >> For x-data-plane=true, we create an iothread automatically for
> >> compatibility. Commit d21e877 ("iothread: include id in thread name")
> >> exposed that this iothread missed correct parenthood: fix this.
> >>
> >> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> >> ---
> >>  hw/block/dataplane/virtio-blk.c | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
> >> index c42ddeb..c7e5668 100644
> >> --- a/hw/block/dataplane/virtio-blk.c
> >> +++ b/hw/block/dataplane/virtio-blk.c
> >> @@ -187,6 +187,9 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *conf,
> >>          object_initialize(&s->internal_iothread_obj,
> >>                            sizeof(s->internal_iothread_obj),
> >>                            TYPE_IOTHREAD);
> >> +        object_property_add_child(OBJECT(conf), TYPE_IOTHREAD,
> >> +                                  OBJECT(&s->internal_iothread_obj),
> >> +                                  &error_abort);
> >>          user_creatable_complete(OBJECT(&s->internal_iothread_obj), &error_abort);
> >>          s->iothread = &s->internal_iothread_obj;
> >>      }
> >
> > Scratch that, does not work... (I thought I was hitting the other
> > segfault in the block backend processing...)
> 
> Should I go ahead and apply Fam's "remove x-data-plane" patch then?

That's probably the quickest solution, as the iothread name patch is
useful and I haven't been able to come up with a correct patch.