* [Qemu-devel] [PATCH for-2.5] virtio-blk/dataplane: parentize compat iothread
@ 2015-12-07 15:50 Cornelia Huck
2015-12-07 16:27 ` Cornelia Huck
0 siblings, 1 reply; 4+ messages in thread
From: Cornelia Huck @ 2015-12-07 15:50 UTC (permalink / raw)
To: qemu-devel, qemu-block
Cc: kwolf, peter.maydell, famz, stefanha, Cornelia Huck, pbonzini
For x-data-plane=true, we create an iothread automatically for
compatibility. Commit d21e877 ("iothread: include id in thread name")
exposed that this iothread missed correct parenthood: fix this.
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
hw/block/dataplane/virtio-blk.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
index c42ddeb..c7e5668 100644
--- a/hw/block/dataplane/virtio-blk.c
+++ b/hw/block/dataplane/virtio-blk.c
@@ -187,6 +187,9 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *conf,
object_initialize(&s->internal_iothread_obj,
sizeof(s->internal_iothread_obj),
TYPE_IOTHREAD);
+ object_property_add_child(OBJECT(conf), TYPE_IOTHREAD,
+ OBJECT(&s->internal_iothread_obj),
+ &error_abort);
user_creatable_complete(OBJECT(&s->internal_iothread_obj), &error_abort);
s->iothread = &s->internal_iothread_obj;
}
--
2.3.9
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH for-2.5] virtio-blk/dataplane: parentize compat iothread
2015-12-07 15:50 [Qemu-devel] [PATCH for-2.5] virtio-blk/dataplane: parentize compat iothread Cornelia Huck
@ 2015-12-07 16:27 ` Cornelia Huck
2015-12-07 16:33 ` Peter Maydell
0 siblings, 1 reply; 4+ messages in thread
From: Cornelia Huck @ 2015-12-07 16:27 UTC (permalink / raw)
To: qemu-devel, qemu-block; +Cc: kwolf, peter.maydell, famz, stefanha, pbonzini
On Mon, 7 Dec 2015 16:50:01 +0100
Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
> For x-data-plane=true, we create an iothread automatically for
> compatibility. Commit d21e877 ("iothread: include id in thread name")
> exposed that this iothread missed correct parenthood: fix this.
>
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> ---
> hw/block/dataplane/virtio-blk.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
> index c42ddeb..c7e5668 100644
> --- a/hw/block/dataplane/virtio-blk.c
> +++ b/hw/block/dataplane/virtio-blk.c
> @@ -187,6 +187,9 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *conf,
> object_initialize(&s->internal_iothread_obj,
> sizeof(s->internal_iothread_obj),
> TYPE_IOTHREAD);
> + object_property_add_child(OBJECT(conf), TYPE_IOTHREAD,
> + OBJECT(&s->internal_iothread_obj),
> + &error_abort);
> user_creatable_complete(OBJECT(&s->internal_iothread_obj), &error_abort);
> s->iothread = &s->internal_iothread_obj;
> }
Scratch that, does not work... (I thought I was hitting the other
segfault in the block backend processing...)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH for-2.5] virtio-blk/dataplane: parentize compat iothread
2015-12-07 16:27 ` Cornelia Huck
@ 2015-12-07 16:33 ` Peter Maydell
2015-12-07 16:46 ` Cornelia Huck
0 siblings, 1 reply; 4+ messages in thread
From: Peter Maydell @ 2015-12-07 16:33 UTC (permalink / raw)
To: Cornelia Huck
Cc: Kevin Wolf, Fam Zheng, Qemu-block, QEMU Developers,
Stefan Hajnoczi, Paolo Bonzini
On 7 December 2015 at 16:27, Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
> On Mon, 7 Dec 2015 16:50:01 +0100
> Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
>
>> For x-data-plane=true, we create an iothread automatically for
>> compatibility. Commit d21e877 ("iothread: include id in thread name")
>> exposed that this iothread missed correct parenthood: fix this.
>>
>> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>> ---
>> hw/block/dataplane/virtio-blk.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
>> index c42ddeb..c7e5668 100644
>> --- a/hw/block/dataplane/virtio-blk.c
>> +++ b/hw/block/dataplane/virtio-blk.c
>> @@ -187,6 +187,9 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *conf,
>> object_initialize(&s->internal_iothread_obj,
>> sizeof(s->internal_iothread_obj),
>> TYPE_IOTHREAD);
>> + object_property_add_child(OBJECT(conf), TYPE_IOTHREAD,
>> + OBJECT(&s->internal_iothread_obj),
>> + &error_abort);
>> user_creatable_complete(OBJECT(&s->internal_iothread_obj), &error_abort);
>> s->iothread = &s->internal_iothread_obj;
>> }
>
> Scratch that, does not work... (I thought I was hitting the other
> segfault in the block backend processing...)
Should I go ahead and apply Fam's "remove x-data-plane" patch then?
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH for-2.5] virtio-blk/dataplane: parentize compat iothread
2015-12-07 16:33 ` Peter Maydell
@ 2015-12-07 16:46 ` Cornelia Huck
0 siblings, 0 replies; 4+ messages in thread
From: Cornelia Huck @ 2015-12-07 16:46 UTC (permalink / raw)
To: Peter Maydell
Cc: Kevin Wolf, Fam Zheng, Qemu-block, QEMU Developers,
Stefan Hajnoczi, Paolo Bonzini
On Mon, 7 Dec 2015 16:33:11 +0000
Peter Maydell <peter.maydell@linaro.org> wrote:
> On 7 December 2015 at 16:27, Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
> > On Mon, 7 Dec 2015 16:50:01 +0100
> > Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
> >
> >> For x-data-plane=true, we create an iothread automatically for
> >> compatibility. Commit d21e877 ("iothread: include id in thread name")
> >> exposed that this iothread missed correct parenthood: fix this.
> >>
> >> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> >> ---
> >> hw/block/dataplane/virtio-blk.c | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >> diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
> >> index c42ddeb..c7e5668 100644
> >> --- a/hw/block/dataplane/virtio-blk.c
> >> +++ b/hw/block/dataplane/virtio-blk.c
> >> @@ -187,6 +187,9 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *conf,
> >> object_initialize(&s->internal_iothread_obj,
> >> sizeof(s->internal_iothread_obj),
> >> TYPE_IOTHREAD);
> >> + object_property_add_child(OBJECT(conf), TYPE_IOTHREAD,
> >> + OBJECT(&s->internal_iothread_obj),
> >> + &error_abort);
> >> user_creatable_complete(OBJECT(&s->internal_iothread_obj), &error_abort);
> >> s->iothread = &s->internal_iothread_obj;
> >> }
> >
> > Scratch that, does not work... (I thought I was hitting the other
> > segfault in the block backend processing...)
>
> Should I go ahead and apply Fam's "remove x-data-plane" patch then?
That's probably the quickest solution, as the iothread name patch is
useful and I haven't been able to come up with a correct patch.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-07 16:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-07 15:50 [Qemu-devel] [PATCH for-2.5] virtio-blk/dataplane: parentize compat iothread Cornelia Huck
2015-12-07 16:27 ` Cornelia Huck
2015-12-07 16:33 ` Peter Maydell
2015-12-07 16:46 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).