From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54052) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6EDk-0001Ha-SH for qemu-devel@nongnu.org; Tue, 08 Dec 2015 04:06:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6EDg-0006wT-S2 for qemu-devel@nongnu.org; Tue, 08 Dec 2015 04:06:04 -0500 Date: Tue, 8 Dec 2015 15:40:28 +1100 From: David Gibson Message-ID: <20151208044028.GL20139@voom.fritz.box> References: <1449546921-6378-1-git-send-email-eblake@redhat.com> <1449546921-6378-15-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hTKW8p8tUZ/8vLMe" Content-Disposition: inline In-Reply-To: <1449546921-6378-15-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH v7 14/31] qapi: Drop unused error argument for list and implicit struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Michael Roth , Alexander Graf , "open list:sPAPR (pseries)" , qemu-devel@nongnu.org, armbru@redhat.com --hTKW8p8tUZ/8vLMe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 07, 2015 at 08:55:04PM -0700, Eric Blake wrote: > No backend was setting an error when ending the visit of a list > or implicit struct. Make the callers a bit easier to follow by > making this a part of the contract, and removing the errp > argument - callers can then unconditionally end an object as > part of cleanup without having to think about whether a second > error is dominated by a first, because there is no second error. >=20 > A later patch will then tackle the larger task of splitting > visit_end_struct(), which can indeed set an error. >=20 > Signed-off-by: Eric Blake For spapr parts: Acked-by: David Gibson --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --hTKW8p8tUZ/8vLMe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWZl88AAoJEGw4ysog2bOSHAQP/2ShEMQAGRDaSa5man6GFxt3 iNRofjaETxq9Up57g3whvUBFeDI1p2ToH1sZt0u/IeJYXyduEkGWubq2mZuQI8IO 8qtlfL/JHzN+v4IiqO6auaIjr5XaNzUHbk8E/veU05zT8eQQMeRCIVv8yIWZXFf5 0DvhrAmBWBih5vxhbY2yNykmyGDHREU+iwr7HtmvWpL60xds3rc3Q+stzJtRjsqF qHQonDzssHij9VzqKakG3zv19JWSHD063YpFG3POcUmTiInkhW1VQzf/T5hFQjmF 2p586Cf6w0iA5jurUQJK0gNGx/CU4I9cGZHYyFiCdzCb+JbJdl1hDy6lfJh14qaO Fn0elvvvHT9248nMSmsuCnTHv64uYgqW/yZg13D/Q+Yna1HKw6+qWBvU6f8DAnBN wvYdHSE8NiMbCXyrxqTVQtUao2T7xDXKkgW/5mVPAqztF0meXLwEUgs5pnqKe9vx 8gPo7wRNu5byxEicgtzwE5lUJc/JhU60DU2yZQlb+f8vKDDGi8VQLQe2jaj+wLxD ZYvAzQHdcqtpTeMOF6vTX5bMqZmQNO/1aIgvY0ZBinG7uBG1+4vJ/z4D0xyiqLq/ w70smMacWWsHnViMHSSkBFgZLdP1Cyg1Ge7qMPo9JaX8Smve7FNto9E6ZB1KZah7 cN4LyHnWhvnAAXYs/g+u =8+fY -----END PGP SIGNATURE----- --hTKW8p8tUZ/8vLMe--