From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: "Denis V. Lunev" <den@openvz.org>,
Roman Kagan <rkagan@virtuozzo.com>,
qemu-block@nongnu.org,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH for-2.5?] qcow2: always initialize specific image info
Date: Tue, 8 Dec 2015 10:37:21 +0100 [thread overview]
Message-ID: <20151208093721.GC5071@noname.str.redhat.com> (raw)
In-Reply-To: <5665E186.1030701@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 295 bytes --]
Am 07.12.2015 um 20:44 hat Max Reitz geschrieben:
> I'd be completely fine with adding an "else { abort(); }" branch to
> qcow2_get_specific_info().
This is actually what I was going to suggest, too. Of course, it's not
supposed to fix anything now, but defensive coding has never hurt.
Kevin
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2015-12-08 9:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1449508029-14664-1-git-send-email-rkagan@virtuozzo.com>
2015-12-07 17:51 ` [Qemu-devel] [Qemu-block] [PATCH for-2.5] qcow2: always initialize specific image info Eric Blake
2015-12-07 17:54 ` [Qemu-devel] [Qemu-block] [PATCH for-2.5?] " Eric Blake
2015-12-07 18:11 ` Denis V. Lunev
2015-12-07 19:44 ` Max Reitz
2015-12-08 9:37 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208093721.GC5071@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=den@openvz.org \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rkagan@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).