From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33587)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1a6Ei8-0007VT-Pd
	for qemu-devel@nongnu.org; Tue, 08 Dec 2015 04:37:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1a6Ei8-0006KL-1n
	for qemu-devel@nongnu.org; Tue, 08 Dec 2015 04:37:28 -0500
Date: Tue, 8 Dec 2015 10:37:21 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20151208093721.GC5071@noname.str.redhat.com>
References: <1449508029-14664-1-git-send-email-rkagan@virtuozzo.com>
	<5665C732.4010107@redhat.com> <5665C7BB.8040601@redhat.com>
	<5665CBB7.6030201@openvz.org> <5665E186.1030701@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="uAKRQypu60I7Lcqm"
Content-Disposition: inline
In-Reply-To: <5665E186.1030701@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH for-2.5?] qcow2: always
 initialize specific image info
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: "Denis V. Lunev" <den@openvz.org>, Roman Kagan <rkagan@virtuozzo.com>, qemu-block@nongnu.org, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>


--uAKRQypu60I7Lcqm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Am 07.12.2015 um 20:44 hat Max Reitz geschrieben:
> I'd be completely fine with adding an "else { abort(); }" branch to
> qcow2_get_specific_info().

This is actually what I was going to suggest, too. Of course, it's not
supposed to fix anything now, but defensive coding has never hurt.

Kevin

--uAKRQypu60I7Lcqm
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJWZqTRAAoJEH8JsnLIjy/WMSgQAKy2YY65yvf+6u92CUkzDCSV
wU9o/Trx71UtFVBS/Hq+c3BkAjSCNU8JG1se2+rwNSfQC5BSEorwI6MDlz4Odck8
le2MxAYKhlKxoHLIXDuG4FVv+ynobKthstGmkmffuIMCIJB6YcbTNOlhSdM3F/Qc
RriX4GiqWWv7uFi8AjxfCuf1vUPTkffefftlE2LGUMzVNs1qoOvxrHNHEFVgSyaK
AulYwdQf9yM81H2oJ6LJzDdSZG4ZpmcgbHLwLXjhVcRJqZW4uF748eK/r3fD2cic
GJV+KtEJqlp8XkcXZ/8JQtCwCzwsawF6QMK1W8X7bWHzqz1TPROp1yX9VJpyQiEO
Eq/G1hePDetFIcCxxQdaSDRE+xo41m27cXHnjjRfUxL7K5UcNgJxkihM34f5k7Gp
zew7yGB5MQyJM5SM6GMlh13d1aN3YC59mAlZq3P4NXrTSasciU/SSJ+qPq+t1HB1
hsdbvF2N6wLTxfFNPUohvQnMz+S5rc8rc1s9Xi9b0M8i21DhPycF9SXCV+v+xT1v
M5O6/zsPy7byu2Wn9LtZmOHyLAfolj+akfqa2iF1ZEfYSNYbh79GxmVWxue+hWJk
v3Lk8JXU0SWA23oTG/BeyuQqPYPYsKCMnt6UCKH2N3wEVT7wXfZjG2nCitSvoa1D
edsOHxug5dvIT9VN0y6E
=alcP
-----END PGP SIGNATURE-----

--uAKRQypu60I7Lcqm--