From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a71TZ-0000NY-D4 for qemu-devel@nongnu.org; Thu, 10 Dec 2015 08:41:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a71TU-0006aZ-Nt for qemu-devel@nongnu.org; Thu, 10 Dec 2015 08:41:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45556) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a71TU-0006aU-Il for qemu-devel@nongnu.org; Thu, 10 Dec 2015 08:41:36 -0500 Date: Thu, 10 Dec 2015 14:41:30 +0100 From: Igor Mammedov Message-ID: <20151210144130.4e3cb1da@igors-macbook-pro.local> In-Reply-To: <5669786B.8060104@gmail.com> References: <1449704528-289297-1-git-send-email-imammedo@redhat.com> <1449704528-289297-11-git-send-email-imammedo@redhat.com> <5669786B.8060104@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/74] acpi: add aml_call0() helper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: qemu-devel@nongnu.org On Thu, 10 Dec 2015 15:04:43 +0200 Marcel Apfelbaum wrote: > On 12/10/2015 01:41 AM, Igor Mammedov wrote: > > it will help to call a method with 0 arguments > > > > Signed-off-by: Igor Mammedov > > --- > > hw/acpi/aml-build.c | 8 ++++++++ > > include/hw/acpi/aml-build.h | 1 + > > 2 files changed, 9 insertions(+) > > > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > > index ee34771..50587de 100644 > > --- a/hw/acpi/aml-build.c > > +++ b/hw/acpi/aml-build.c > > @@ -540,6 +540,14 @@ Aml *aml_notify(Aml *arg1, Aml *arg2) > > } > > > > /* helper to call method with 1 argument */ > > +Aml *aml_call0(const char *method) > > +{ > > + Aml *var = aml_alloc(); > > + build_append_namestring(var->buf, "%s", method); > > + return var; > > +} > > + > > +/* helper to call method with 1 argument */ > > Aml *aml_call1(const char *method, Aml *arg1) > > { > > Aml *var = aml_alloc(); > > diff --git a/include/hw/acpi/aml-build.h > > b/include/hw/acpi/aml-build.h index 9761438..117ef46 100644 > > --- a/include/hw/acpi/aml-build.h > > +++ b/include/hw/acpi/aml-build.h > > @@ -210,6 +210,7 @@ Aml *aml_increment(Aml *arg); > > Aml *aml_decrement(Aml *arg); > > Aml *aml_index(Aml *arg1, Aml *idx); > > Aml *aml_notify(Aml *arg1, Aml *arg2); > > +Aml *aml_call0(const char *method); > > Aml *aml_call1(const char *method, Aml *arg1); > > Aml *aml_call2(const char *method, Aml *arg1, Aml *arg2); > > Aml *aml_call3(const char *method, Aml *arg1, Aml *arg2, Aml > > *arg3); > > > > Maybe aml_call instead of aml_call0 that implies some 'zero' > initialization? It doesn't really matter. it's named so for consistency with other aml_callX() helpers. > > Reviewed-by: Marcel Apfelbaum >