Re: [Qemu-devel] [PATCH 00/74] pc: acpi: convert DSDT to AML API and drop ASL templates support

[Igor Mammedov <imammedo@redhat.com>]

On Thu, 10 Dec 2015 17:53:31 +0200
Marcel Apfelbaum <marcel.apfelbaum@gmail.com> wrote:

[...]
> Hi Igor,
> Please consider splinting this series...
> 
> Maybe ACPI new constructs first, then memhp/cpu, piix/q35. (only a
> suggestion) In this you will have some "sane" 20 something patches
> series that can be more easily "swallowed".
I'd also prefer to do it incrementally but
I've tried something like this before, but Michael suggested to
avoid optimizations/refactoring and make it so that conversion would
pass 'make check' so it would be easy to prove that it hasn't regressed
anything and to do it the only way is to convert whole DSDT at once.

Nevertheless, the series more or less organized with split in mind,
so it's possible first commit AML API patches ('acpi:' prefixed)
and then just go in order the blocks as they are in series:

memhp/cpuhp/misc devices/piix4/q35/final cleanup


> 
> Thanks,
> Marcel
> 
> >
> > CC: "Michael S. Tsirkin" <mst@redhat.com> (supporter:ACPI/SMBIOS)
> > CC: Shannon Zhao <zhaoshenglong@huawei.com> (maintainer:ARM ACPI
> > Subsystem) CC: Peter Maydell <peter.maydell@linaro.org>
> > (maintainer:ARM) CC: Paolo Bonzini <pbonzini@redhat.com>
> > (maintainer:X86) CC: Richard Henderson <rth@twiddle.net>
> > (maintainer:X86) CC: Eduardo Habkost <ehabkost@redhat.com>
> > (maintainer:X86) CC: qemu-arm@nongnu.org (open list:ARM ACPI
> > Subsystem)
> >
> > Igor Mammedov (70):
> >    tests: acpi: print ASL diff in verbose mode
> >    acpi: add aml_lgreater_equal()
> >    acpi: add aml_create_qword_field()
> >    acpi: aml: add helper for Opcode Arg2 Arg2 [Dst] AML pattern
> >    acpi: extend aml_add() to accept target argument
> >    acpi: add aml_decrement() and aml_subtract()
> >    acpi: add aml_call0() helper
> >    acpi: add aml_to_integer()
> >    acpi: extend aml_shiftright() to accept target argument
> >    acpi: add aml_alias()
> >    acpi: add aml_sleep()
> >    acpi: add aml_lor()
> >    acpi: add aml_lgreater()
> >    acpi: extend aml_field() to support LockRule
> >    acpi: add aml_to_hexstring()
> >    acpi: add aml_to_buffer()
> >    acpi add aml_dma()
> >    acpi: extend aml_or() to accept target argument
> >    acpi: extend aml_and() to accept target argument
> >    acpi: extend aml_interrupt() to support multiple irqs
> >    pc: acpi: memhp: prepare context in SSDT for moving memhp DSDT
> > code pc: acpi: memhp: move MHPD._STA method into SSDT
> >    pc: acpi: memhp: move MHPD.MLCK mutex into SSDT
> >    pc: acpi: memhp: move MHPD.MSCN method into SSDT
> >    pc: acpi: memhp: move MHPD.MRST method into SSDT
> >    pc: acpi: memhp: move MHPD.MPXM method into SSDT
> >    pc: acpi: memhp: move MHPD.MOST method into SSDT
> >    pc: acpi: memhp: move MHPD.MEJ0 method into SSDT
> >    pc: acpi: memhp: move MHPD.MCRS method into SSDT
> >    pc: acpi: memhp: move MHPD Device into SSDT
> >    pc: acpi: factor out memhp code from build_ssdt() into separate
> >      function
> >    pc: acpi: memhp: move \_GPE._E03 into SSDT
> >    pc: acpi: memhp: drop not needed stringify(MEMORY_foo) usage
> >    pc: acpi: drop unused CPU_STATUS_LEN from DSDT
> >    pc: acpi: cpuhp: move CPEJ() method to SSDT
> >    pc: acpi: cpuhp: move CPMA() method into SSDT
> >    pc: acpi: cpuhp: move CPST() method into SSDT
> >    pc: acpi: cpuhp: move PRSC() method into SSDT
> >    pc: acpi: cpuhp: move \_GPE._E02() into SSDT
> >    pc: acpi: factor out cpu hotplug code from build_ssdt() into
> > separate function
> >    pc: acpi: move HPET from DSDT to SSDT
> >    pc: acpi: move DBUG() from DSDT to SSDT
> >    pc: acpi: move RTC device from DSDT to SSDT
> >    pc: acpi: move KBD device from DSDT to SSDT
> >    pc: acpi: move MOU device from DSDT to SSDT
> >    pc: acpi: move FDC0 device from DSDT to SSDT
> >    pc: acpi: move LPT device from DSDT to SSDT
> >    pc: acpi: move COM devices from DSDT to SSDT
> >    pc: acpi: move PIIX4 isa-bridge and pm devices into SSDT
> >    pc: acpi: move remaining GPE handlers into SSDT
> >    pc: acpi: pci: move link devices into SSDT
> >    pc: acpi: piix4: move IQCR() into SSDT
> >    pc: acpi: piix4: move IQST() into SSDT
> >    pc: acpi: piix4: move PCI0._PRT() into SSDT
> >    pc: acpi: piix4: move remaining PCI hotplug bits into SSDT
> >    pc: acpi: piix4: acpi move PCI0 device to SSDT
> >    pc: acpi: q35: move GSI links to SSDT
> >    pc: acpi: q35: move link devices to SSDT
> >    pc: acpi: q35: move IQCR() into SSDT
> >    pc: acpi: q35: move IQST() into SSDT
> >    pc: acpi: q35: move ISA bridge into SSDT
> >    pc: acpi: q35: move _PRT() into SSDT
> >    pc: acpi: q35: move PRTA routing table into SSDT
> >    pc: acpi: q35: move PRTP routing table into SSDT
> >    pc: acpi: q35: move _PIC() method into SSDT
> >    pc: acpi: q35: move PCI0._OSC() method into SSDT
> >    pc: acpi: q35: move PCI0 device definition into SSDT
> >    pc: acpi: q35: PCST, PCSB opregions and PCIB field into SSDT
> >    pc: acpi: switch to AML API composed DSDT
> >    pc: acpi: remove unused ASL templates and related blobs/utils
> >
> > Xiao Guangrong (4):
> >    acpi: add aml_derefof
> >    acpi: add aml_sizeof
> >    acpi: add aml_mutex(), aml_acquire(), aml_release()
> >    acpi: support serialized method
> >
> >   hw/acpi/Makefile.objs               |    4 +-
> >   hw/acpi/aml-build.c                 |  294 +-
> >   hw/acpi/cpu_hotplug_acpi_table.c    |  124 +
> >   hw/acpi/memory_hotplug_acpi_table.c |  249 ++
> >   hw/arm/virt-acpi-build.c            |   41 +-
> >   hw/i386/Makefile.objs               |   31 +-
> >   hw/i386/acpi-build.c                | 1329 ++++--
> >   hw/i386/acpi-dsdt-cpu-hotplug.dsl   |   90 -
> >   hw/i386/acpi-dsdt-dbug.dsl          |   41 -
> >   hw/i386/acpi-dsdt-hpet.dsl          |   48 -
> >   hw/i386/acpi-dsdt-isa.dsl           |  117 -
> >   hw/i386/acpi-dsdt-mem-hotplug.dsl   |  171 -
> >   hw/i386/acpi-dsdt.dsl               |  303 --
> >   hw/i386/acpi-dsdt.hex.generated     | 2972 --------------
> >   hw/i386/q35-acpi-dsdt.dsl           |  436 --
> >   hw/i386/q35-acpi-dsdt.hex.generated | 7610
> > -----------------------------------
> > hw/timer/hpet.c                     |    2 +-
> > include/hw/acpi/aml-build.h         |   66 +-
> > include/hw/acpi/cpu_hotplug.h       |   10 +
> > include/hw/acpi/memory_hotplug.h    |    9 +
> > include/hw/acpi/pc-hotplug.h        |   44 +-
> > include/hw/timer/hpet.h             |    1 +
> > scripts/acpi_extract.py             |  367 --
> > scripts/acpi_extract_preprocess.py  |   51 -
> > scripts/update-acpi.sh              |    4 -
> > tests/bios-tables-test.c            |    7 + 26 files changed, 1848
> > insertions(+), 12573 deletions(-) create mode 100644
> > hw/acpi/cpu_hotplug_acpi_table.c create mode 100644
> > hw/acpi/memory_hotplug_acpi_table.c delete mode 100644
> > hw/i386/acpi-dsdt-cpu-hotplug.dsl delete mode 100644
> > hw/i386/acpi-dsdt-dbug.dsl delete mode 100644
> > hw/i386/acpi-dsdt-hpet.dsl delete mode 100644
> > hw/i386/acpi-dsdt-isa.dsl delete mode 100644
> > hw/i386/acpi-dsdt-mem-hotplug.dsl delete mode 100644
> > hw/i386/acpi-dsdt.dsl delete mode 100644
> > hw/i386/acpi-dsdt.hex.generated delete mode 100644
> > hw/i386/q35-acpi-dsdt.dsl delete mode 100644
> > hw/i386/q35-acpi-dsdt.hex.generated delete mode 100755
> > scripts/acpi_extract.py delete mode 100755
> > scripts/acpi_extract_preprocess.py delete mode 100644
> > scripts/update-acpi.sh
> >
>