From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47597)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1a7O12-0005QZ-CR
	for qemu-devel@nongnu.org; Fri, 11 Dec 2015 08:45:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1a7O0x-0001s2-9S
	for qemu-devel@nongnu.org; Fri, 11 Dec 2015 08:45:44 -0500
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:51959)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1a7O0x-0001rv-26
	for qemu-devel@nongnu.org; Fri, 11 Dec 2015 08:45:39 -0500
Date: Fri, 11 Dec 2015 14:45:37 +0100
From: Samuel Thibault <samuel.thibault@gnu.org>
Message-ID: <20151211134537.GB2927@var.bordeaux.inria.fr>
References: <20151211001505.GV2905@var.home>
	<1449792930-27293-1-git-send-email-samuel.thibault@ens-lyon.org>
	<1449792930-27293-2-git-send-email-samuel.thibault@ens-lyon.org>
	<566AD1E4.1050403@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <566AD1E4.1050403@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing
 code before adding IPv6 stuff
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Huth <thuth@redhat.com>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>, Li Zhijian <lizhijian@cn.fujitsu.com>, Stefan Hajnoczi <stefanha@gmail.com>, Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org, Vasiliy Tolstov <v.tolstov@selfip.ru>, Dave Gilbert <dgilbert@redhat.com>, Gonglei <arei.gonglei@huawei.com>, Jan Kiszka <jan.kiszka@siemens.com>, Huangpeng <peter.huangpeng@huawei.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, Guillaume Subiron <maethor@subiron.org>

Thomas Huth, on Fri 11 Dec 2015 14:38:44 +0100, wrote:
> > +    switch (iph->ip_v) {
> > +    case IPVERSION:
> >      if (iph->ip_dst.s_addr == 0) {
> >          /* 0.0.0.0 can not be a destination address, something went wrong,
> >           * avoid making it worse */
> 
> That indentation looks now broken - shouldn't the if-statement now be
> indented with four more spaces now?

Please see the patch summary: I was asked to provided a non-reindented
patch and then a reindent patch.

> Also, I'd prefer if you could split this patch into two: One for
> renaming the "arp_requested" field, and one for adding the additional
> logic with the switch statement (since there are two different kind of
> changes).

TBH I'm starting to again lose motivation.

Samuel