From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51257)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1a7OGK-0000p8-Bn
	for qemu-devel@nongnu.org; Fri, 11 Dec 2015 09:01:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1a7OGE-0005cA-HM
	for qemu-devel@nongnu.org; Fri, 11 Dec 2015 09:01:32 -0500
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:10124)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1a7OGE-0005bo-BL
	for qemu-devel@nongnu.org; Fri, 11 Dec 2015 09:01:26 -0500
Date: Fri, 11 Dec 2015 15:01:24 +0100
From: Samuel Thibault <samuel.thibault@gnu.org>
Message-ID: <20151211140124.GE2927@var.bordeaux.inria.fr>
References: <20151211001505.GV2905@var.home>
	<1449792930-27293-1-git-send-email-samuel.thibault@ens-lyon.org>
	<1449792930-27293-2-git-send-email-samuel.thibault@ens-lyon.org>
	<566AD1E4.1050403@redhat.com> <566AD30E.2060002@redhat.com>
	<566AD45C.20000@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <566AD45C.20000@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing
 code before adding IPv6 stuff
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Huth <thuth@redhat.com>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>, Li Zhijian <lizhijian@cn.fujitsu.com>, Stefan Hajnoczi <stefanha@gmail.com>, Jason Wang <jasowang@redhat.com>, Dave Gilbert <dgilbert@redhat.com>, Vasiliy Tolstov <v.tolstov@selfip.ru>, qemu-devel@nongnu.org, Gonglei <arei.gonglei@huawei.com>, Jan Kiszka <jan.kiszka@siemens.com>, Huangpeng <peter.huangpeng@huawei.com>, Guillaume Subiron <maethor@subiron.org>

Just to explain.

I'm fine with revamping the patches, provided that we eventually
converge somewhere.

What I'm afraid of is that splitting patches in yet more many pieces,
revamping the code yet more (moving code into their own functions, etc.)
will only make the patch series look even bigger and even less prone to
be included for lack of reviewer time.

I agree that the presentation can be looked after. But if that makes the
patch series much bigger, I'd really prefer to look after that once the
content gets commited, otherwise I don't see how we'll ever manage to
get this commited in the coming decade.

Samuel