From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7U1v-0008Lm-43 for qemu-devel@nongnu.org; Fri, 11 Dec 2015 15:11:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a7U1q-0006te-4z for qemu-devel@nongnu.org; Fri, 11 Dec 2015 15:11:03 -0500 Received: from domu-toccata.ens-lyon.fr ([140.77.166.138]:38581 helo=sonata.ens-lyon.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7U1p-0006tR-Um for qemu-devel@nongnu.org; Fri, 11 Dec 2015 15:10:58 -0500 Date: Fri, 11 Dec 2015 21:10:55 +0100 From: Samuel Thibault Message-ID: <20151211201055.GP2764@var.home> References: <20151211001505.GV2905@var.home> <1449792930-27293-1-git-send-email-samuel.thibault@ens-lyon.org> <1449792930-27293-2-git-send-email-samuel.thibault@ens-lyon.org> <566AD1E4.1050403@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <566AD1E4.1050403@redhat.com> Subject: Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: zhanghailiang , Li Zhijian , Stefan Hajnoczi , Jason Wang , qemu-devel@nongnu.org, Vasiliy Tolstov , Dave Gilbert , Gonglei , Jan Kiszka , Huangpeng , Yang Hongyang , Guillaume Subiron Thomas Huth, on Fri 11 Dec 2015 14:38:44 +0100, wrote: > Also, I'd prefer if you could split this patch into two: One for > renaming the "arp_requested" field, and one for adding the additional > logic with the switch statement (since there are two different kind of > changes). Ok, at least it's easy enough :) Samuel