From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59075) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8X44-00070L-KP for qemu-devel@nongnu.org; Mon, 14 Dec 2015 12:37:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8X40-0004iI-MY for qemu-devel@nongnu.org; Mon, 14 Dec 2015 12:37:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8X40-0004iA-Gz for qemu-devel@nongnu.org; Mon, 14 Dec 2015 12:37:32 -0500 Date: Mon, 14 Dec 2015 19:37:29 +0200 From: "Michael S. Tsirkin" Message-ID: <20151214173729.GA14061@redhat.com> References: <1449994112-7054-1-git-send-email-shmulik.ladkani@ravellosystems.com> <1449994112-7054-6-git-send-email-shmulik.ladkani@ravellosystems.com> <566EF8FD.3080206@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <566EF8FD.3080206@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Dmitry Fleytman , Marcel Apfelbaum , idan.brown@ravellosystems.com, Shmulik Ladkani , qemu-devel@nongnu.org On Mon, Dec 14, 2015 at 06:14:37PM +0100, Paolo Bonzini wrote: > > > On 13/12/2015 09:08, Shmulik Ladkani wrote: > > + pvs_k->parent_dc_realize = dc->realize; > > Marcel, Michael, > > this creates a really nasty dependency on the contents of pci_qdev_realize. > > Can you instead change PCIDeviceClass's pc->is_express to a function > pointer, and provide a sample implementation pci_is_express_true for the > devices that set is_express to true? > > Thanks, > > Paolo I'm not very familiar with vmw code, and I dislike overusing callbacks. What exactly would this callback do? -- MST