From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50969)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from
	<SRS0=bx88=MP=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
	id 1a8bXL-00045y-2I
	for qemu-devel@nongnu.org; Mon, 14 Dec 2015 17:24:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from
	<SRS0=bx88=MP=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
	id 1a8bXH-00025o-TO
	for qemu-devel@nongnu.org; Mon, 14 Dec 2015 17:24:07 -0500
Received: from sonata.ens-lyon.org ([140.77.166.138]:48107)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from
	<SRS0=bx88=MP=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
	id 1a8bXH-00025G-Mo
	for qemu-devel@nongnu.org; Mon, 14 Dec 2015 17:24:03 -0500
Date: Mon, 14 Dec 2015 23:24:01 +0100
From: Samuel Thibault <samuel.thibault@gnu.org>
Message-ID: <20151214222401.GC2967@var.home>
References: <20151214134939.GA3142@var.bordeaux.inria.fr>
	<1450101088-14575-1-git-send-email-samuel.thibault@ens-lyon.org>
	<1450101088-14575-7-git-send-email-samuel.thibault@ens-lyon.org>
	<566F23CF.4050701@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <566F23CF.4050701@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 7/9] slirp: Add sockaddr_equal,
 make solookup family-agnostic
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Huth <thuth@redhat.com>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>, Li Zhijian <lizhijian@cn.fujitsu.com>, Stefan Hajnoczi <stefanha@gmail.com>, Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org, Vasiliy Tolstov <v.tolstov@selfip.ru>, Dave Gilbert <dgilbert@redhat.com>, Gonglei <arei.gonglei@huawei.com>, Jan Kiszka <jan.kiszka@siemens.com>, Huangpeng <peter.huangpeng@huawei.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, Guillaume Subiron <maethor@subiron.org>

Thomas Huth, on Mon 14 Dec 2015 21:17:19 +0100, wrote:
> > +	lhost.ss_family = AF_INET;
> > +	((struct sockaddr_in *)&lhost)->sin_addr = ti->ti_src;
> > +	((struct sockaddr_in *)&lhost)->sin_port = ti->ti_sport;
> > +	fhost.ss_family = AF_INET;
> > +	((struct sockaddr_in *)&fhost)->sin_addr = ti->ti_dst;
> > +	((struct sockaddr_in *)&fhost)->sin_port = ti->ti_dport;
> 
> Couldn't you simply use "fhost.sin.sin_addr = ..." etc. instead of
> casting everything via a pointer?

No, here fhost is a struct sockaddr_storage, which doesn't have a sin
field.  We could define a struct sockaddr_in *fhost4 that would be made
an alias to fhost, but I don't feel it's more readable to introduce an
alias than expliciting those two casts.

Samuel