From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56377)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shmulik.ladkani@ravellosystems.com>)
	id 1a8iTW-0008SE-LQ
	for qemu-devel@nongnu.org; Tue, 15 Dec 2015 00:48:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <shmulik.ladkani@ravellosystems.com>)
	id 1a8iTR-0003Ql-Mo
	for qemu-devel@nongnu.org; Tue, 15 Dec 2015 00:48:38 -0500
Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:36242)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shmulik.ladkani@ravellosystems.com>)
	id 1a8iTR-0003Qg-Fm
	for qemu-devel@nongnu.org; Tue, 15 Dec 2015 00:48:33 -0500
Received: by mail-wm0-x232.google.com with SMTP id n186so148979576wmn.1
	for <qemu-devel@nongnu.org>; Mon, 14 Dec 2015 21:48:33 -0800 (PST)
Date: Tue, 15 Dec 2015 07:48:29 +0200
From: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
Message-ID: <20151215074829.0ffb1496@halley>
In-Reply-To: <20151214230450-mutt-send-email-mst@redhat.com>
References: <1449994112-7054-1-git-send-email-shmulik.ladkani@ravellosystems.com>
	<1449994112-7054-6-git-send-email-shmulik.ladkani@ravellosystems.com>
	<566EF8FD.3080206@redhat.com> <20151214173729.GA14061@redhat.com>
	<20151214230105.6890c641@halley>
	<20151214230450-mutt-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a
 PCIE endpoint
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>, idan.brown@ravellosystems.com, qemu-devel@nongnu.org, Marcel Apfelbaum <marcel@redhat.com>, Dmitry Fleytman <dmitry@daynix.com>, Paolo Bonzini <pbonzini@redhat.com>

Hi,

On Mon, 14 Dec 2015 23:10:20 +0200 "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > In order to set QEMU_PCI_CAP_EXPRESS conditionally per instance
> > (for example, according to the given x-pcie-disable property), the
> > 'parent_dc_realize' trick was suggested.
> > 
> > Reasoning is documented in:
> >   0560b0e9 virtio-pci: Set the QEMU_PCI_CAP_EXPRESS capability early in its DeviceClass realize method
> > 
> > Alas, the same trick needs to be repeated for all classes whose
> > instances may be either pci or pcie.
> 
> Actually, I think you can just move the code to pci core.
> There won't be a need for a callback then.

Michael, can you please elaborate?

Regards,
Shmulik