From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a98u7-0002Yz-H8 for qemu-devel@nongnu.org; Wed, 16 Dec 2015 05:01:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a98u4-0007oN-C6 for qemu-devel@nongnu.org; Wed, 16 Dec 2015 05:01:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50144) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a98u4-0007oH-7E for qemu-devel@nongnu.org; Wed, 16 Dec 2015 05:01:48 -0500 Date: Wed, 16 Dec 2015 10:01:43 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20151216100142.GA2604@work-vm> References: <1450206170-26901-1-git-send-email-dgilbert@redhat.com> <1450206170-26901-5-git-send-email-dgilbert@redhat.com> <56708105.2050508@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56708105.2050508@redhat.com> Subject: Re: [Qemu-devel] [PATCH 4/6] Migration: Emit event at start of pass List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: zhang.zhanghailiang@huawei.com, quintela@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, amit.shah@redhat.com, jdenemar@redhat.com * Eric Blake (eblake@redhat.com) wrote: > On 12/15/2015 12:02 PM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Emit an event each time we sync the dirty bitmap on the source; > > this helps libvirt use postcopy by giving it a kick when it > > might be a good idea to start the postcopy. > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > migration/ram.c | 4 ++++ > > qapi/event.json | 11 +++++++++++ > > 2 files changed, 15 insertions(+) > > > +++ b/qapi/event.json > > @@ -255,6 +255,17 @@ > > 'data': {'status': 'MigrationStatus'}} > > > > ## > > +# @MIGRATION_PASS > > +# > > +# Emitted from the source side of a migration at the start of each pass > > +# (when it syncs the dirty bitmap) > > +# > > +# Since: 2.6 > > Missing documentation of the 'pass' member - is it a counter that says > which pass this event is, incrementing each time through? Thanks; yes, I added the pass parameter afterwards; I'll add: # @pass: An incrementing count (starting at 1 on the first pass) > Also missing docs in events.txt (although that file may go away soon, > once we get Marc-Andre's patches in for automating documentation from > .json files). OK, I'll add the following (docs/qmp-events.txt): MIGRATION_PASS -------------- Emitted from the source side of a migration at the start of each pass (when it syncs the dirty bitmap) Data: - "pass": An incrementing count (starting at 1 on the first pass) Example: {"timestamp": {"seconds": 1449669631, "microseconds": 239225}, "event": "MIGRATION_PASS", "data": {"pass": 2}} Dave > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK