From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9FLa-0000BO-94 for qemu-devel@nongnu.org; Wed, 16 Dec 2015 11:54:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9FLV-0005Ts-If for qemu-devel@nongnu.org; Wed, 16 Dec 2015 11:54:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52827) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9FLV-0005Tf-DE for qemu-devel@nongnu.org; Wed, 16 Dec 2015 11:54:33 -0500 Date: Wed, 16 Dec 2015 17:54:25 +0100 From: Igor Mammedov Message-ID: <20151216175425.7541d545@igors-macbook-pro.local> In-Reply-To: <20151215083809.GI18759@in.ibm.com> References: <1449728144-6223-1-git-send-email-bharata@linux.vnet.ibm.com> <1449728144-6223-3-git-send-email-bharata@linux.vnet.ibm.com> <20151214172949.GC3774@thinpad.lan.raisama.net> <20151215083809.GI18759@in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v0 2/9] cpu: Store CPU typename in MachineState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: peter.maydell@linaro.org, Eduardo Habkost , qemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com, pbonzini@redhat.com, afaerber@suse.de, david@gibson.dropbear.id.au On Tue, 15 Dec 2015 14:08:09 +0530 Bharata B Rao wrote: > On Mon, Dec 14, 2015 at 03:29:49PM -0200, Eduardo Habkost wrote: > > On Thu, Dec 10, 2015 at 11:45:37AM +0530, Bharata B Rao wrote: > > > Storing CPU typename in MachineState lets us to create CPU threads > > > for all architectures in uniform manner from arch-neutral code. > > > > > > TODO: Touching only i386 and spapr targets for now > > > > > > Signed-off-by: Bharata B Rao > > > > Suggestions: > > > > * Name the field "cpu_base_type" to indicate it is the base CPU > > class name, not the actual CPU class name used when creating > > CPUs. > > * Put it in MachineClass, as it may be useful for code that > > runs before machine->init(), in the future. > > Ok. > > > * Maybe make it a CPUClass* field instead of a string? > > In the current use case, this base cpu type string is being passed > to cpu_generic_init(const char *typename, const char *cpu_model) > to create boot time CPUs with given typename and cpu_mode. So for now > the string makes sense for use case. > > Making it CPUClass* would necessiate more changes to > cpu_generic_init(). how about actually leaving it as "cpu_type" and putting in it actual cpu type that could be used with device_add(). that would get rid of keeping and passing around intermediate cpu_model. > > Regards, > Bharata. > >