From: Kevin Wolf <kwolf@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] iotests: Don't mention bdrv_swap in comments
Date: Thu, 17 Dec 2015 09:21:34 +0100 [thread overview]
Message-ID: <20151217082134.GA5874@noname.redhat.com> (raw)
In-Reply-To: <1450328956-25224-3-git-send-email-famz@redhat.com>
Am 17.12.2015 um 06:09 hat Fam Zheng geschrieben:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> tests/qemu-iotests/094 | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tests/qemu-iotests/094 b/tests/qemu-iotests/094
> index 27a2be2..d30c78d 100755
> --- a/tests/qemu-iotests/094
> +++ b/tests/qemu-iotests/094
> @@ -1,6 +1,6 @@
> #!/bin/bash
> #
> -# Test case for drive-mirror to NBD (especially bdrv_swap() on NBD BDS)
> +# Test case for drive-mirror to NBD
> #
> # Copyright (C) 2015 Red Hat, Inc.
> #
> @@ -50,8 +50,6 @@ _send_qemu_cmd $QEMU_HANDLE \
> "{'execute': 'qmp_capabilities'}" \
> 'return'
>
> -# 'format': 'nbd' is not actually "correct", but this is probably the only way
> -# to test bdrv_swap() on an NBD BDS
> _send_qemu_cmd $QEMU_HANDLE \
> "{'execute': 'drive-mirror',
> 'arguments': {'device': 'src',
Just completely removing the comment doesn't seem right to me if we
leave the "bad" option around.
The test seems to be a regression test for what was fixed in commit
f53a829, i.e. a direct effect of bdrv_swap(). This effect can't exist
any more, so we would keep the test just for some additional coverage
for NBD. Do we still need 'format': 'nbd' (if so, with a comment why we
do that) or should we make it 'raw' now?
Kevin
next prev parent reply other threads:[~2015-12-17 8:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 5:09 [Qemu-devel] [PATCH 0/2] Clean up the remainders of bdrv_swap Fam Zheng
2015-12-17 5:09 ` [Qemu-devel] [PATCH 1/2] block: Remove prototype of bdrv_swap from header Fam Zheng
2015-12-17 5:09 ` [Qemu-devel] [PATCH 2/2] iotests: Don't mention bdrv_swap in comments Fam Zheng
2015-12-17 8:21 ` Kevin Wolf [this message]
2015-12-17 12:44 ` Fam Zheng
2015-12-17 12:48 ` Kevin Wolf
2015-12-17 19:07 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151217082134.GA5874@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).