From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9TWM-0001uR-Dz for qemu-devel@nongnu.org; Thu, 17 Dec 2015 03:02:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9TWH-0002uq-EA for qemu-devel@nongnu.org; Thu, 17 Dec 2015 03:02:42 -0500 Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:42059) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9TWH-0002ug-5X for qemu-devel@nongnu.org; Thu, 17 Dec 2015 03:02:37 -0500 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 17 Dec 2015 08:02:34 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 66FFC2190056 for ; Thu, 17 Dec 2015 08:02:24 +0000 (GMT) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tBH82WdL12255616 for ; Thu, 17 Dec 2015 08:02:32 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tBH82WsW007001 for ; Thu, 17 Dec 2015 01:02:32 -0700 Date: Thu, 17 Dec 2015 09:02:28 +0100 From: Greg Kurz Message-ID: <20151217090228.702f9c75@bahia.local> In-Reply-To: <20151118224655.78a7d7ae@bahia.local> References: <20151118162119.9938.45927.stgit@bahia.huguette.org> <20151118224739-mutt-send-email-mst@redhat.com> <20151118224655.78a7d7ae@bahia.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/3] virtio-net/vhost-net: share cross-endian enablement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Cornelia Huck , qemu-devel@nongnu.org On Wed, 18 Nov 2015 22:46:55 +0100 Greg Kurz wrote: > On Wed, 18 Nov 2015 22:48:06 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Nov 18, 2015 at 05:23:00PM +0100, Greg Kurz wrote: > > > Since QEMU 2.4.0, vhost-net uses the cross-endian support of TAP devices to > > > fix vnet headers. In fact, virtio-net can do the same instead of hackily > > > patching headers in virtio_net_hdr_swap(). > > > > > > This series moves the enablement of cross-endian support from vhost-net to > > > virtio-net: both vhost and full emulation can now benefit from it. Of course > > > we keep the current hack to fall back on when the backend doesn't support > > > cross-endian. > > > > > > Thanks! > > This is an optimization rather than a bugfix, right? > > As such I'd rather defer this until after 2.5. > > > > Of course. I'll ping or repost later. > Hi Michael, 2.5 is now released and this series still applies cleanly. Should I repost ? -- Greg > > > --- > > > > > > Greg Kurz (3): > > > virtio-net: use the backend cross-endian capabilities > > > Revert "vhost-net: tell tap backend about the vnet endianness" > > > virtio: drop the virtio_needs_swap() helper > > > > > > > > > hw/net/vhost_net.c | 33 +------------------------------ > > > hw/net/virtio-net.c | 40 +++++++++++++++++++++++++++++++++++-- > > > include/hw/virtio/virtio-access.h | 9 -------- > > > include/hw/virtio/virtio-net.h | 1 + > > > 4 files changed, 40 insertions(+), 43 deletions(-) > > > >