From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52276)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1a9XzH-0000GP-7v
	for qemu-devel@nongnu.org; Thu, 17 Dec 2015 07:48:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1a9XzF-0004Mr-Do
	for qemu-devel@nongnu.org; Thu, 17 Dec 2015 07:48:50 -0500
Date: Thu, 17 Dec 2015 13:48:42 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20151217124842.GB5874@noname.redhat.com>
References: <1450328956-25224-1-git-send-email-famz@redhat.com>
	<1450328956-25224-3-git-send-email-famz@redhat.com>
	<20151217082134.GA5874@noname.redhat.com>
	<20151217124415.GC26335@ad.usersys.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151217124415.GC26335@ad.usersys.redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] iotests: Don't mention bdrv_swap in
	comments
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org

Am 17.12.2015 um 13:44 hat Fam Zheng geschrieben:
> On Thu, 12/17 09:21, Kevin Wolf wrote:
> > Am 17.12.2015 um 06:09 hat Fam Zheng geschrieben:
> > > Signed-off-by: Fam Zheng <famz@redhat.com>
> > > ---
> > >  tests/qemu-iotests/094 | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > > 
> > > diff --git a/tests/qemu-iotests/094 b/tests/qemu-iotests/094
> > > index 27a2be2..d30c78d 100755
> > > --- a/tests/qemu-iotests/094
> > > +++ b/tests/qemu-iotests/094
> > > @@ -1,6 +1,6 @@
> > >  #!/bin/bash
> > >  #
> > > -# Test case for drive-mirror to NBD (especially bdrv_swap() on NBD BDS)
> > > +# Test case for drive-mirror to NBD
> > >  #
> > >  # Copyright (C) 2015 Red Hat, Inc.
> > >  #
> > > @@ -50,8 +50,6 @@ _send_qemu_cmd $QEMU_HANDLE \
> > >      "{'execute': 'qmp_capabilities'}" \
> > >      'return'
> > >  
> > > -# 'format': 'nbd' is not actually "correct", but this is probably the only way
> > > -# to test bdrv_swap() on an NBD BDS
> > >  _send_qemu_cmd $QEMU_HANDLE  \
> > >      "{'execute': 'drive-mirror',
> > >        'arguments': {'device': 'src',
> > 
> > Just completely removing the comment doesn't seem right to me if we
> > leave the "bad" option around.
> > 
> > The test seems to be a regression test for what was fixed in commit
> > f53a829, i.e. a direct effect of bdrv_swap(). This effect can't exist
> > any more, so we would keep the test just for some additional coverage
> > for NBD. Do we still need 'format': 'nbd' (if so, with a comment why we
> > do that) or should we make it 'raw' now?
> > 
> 
> I prefer keeping it as is, because making it raw would spoil the purpose as a
> regression test (the fix was on nbd).
> 
> Can we re-comment it as below?
> 
>     # 'format': 'nbd' is not actually "correct", but this was the only way to
>     # test the bug fixed in commit f53a829.  Though the bug's related code
>     # bdrv_swap() was replaced later, let's make sure we don't fall in the same
>     # pit again.

That's fine with me.

Kevin