From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9Y1g-0002Bf-Ep for qemu-devel@nongnu.org; Thu, 17 Dec 2015 07:51:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9Y1d-0005JZ-7p for qemu-devel@nongnu.org; Thu, 17 Dec 2015 07:51:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42488) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9Y1d-0005JD-2E for qemu-devel@nongnu.org; Thu, 17 Dec 2015 07:51:17 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id A7E2B8A14F for ; Thu, 17 Dec 2015 12:51:16 +0000 (UTC) Date: Thu, 17 Dec 2015 12:51:13 +0000 From: "Daniel P. Berrange" Message-ID: <20151217125113.GG16238@redhat.com> References: <1450353308-2082-1-git-send-email-berrange@redhat.com> <5672A3E9.4020900@redhat.com> <20151217120248.GF16238@redhat.com> <5672AF5C.9080803@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5672AF5C.9080803@redhat.com> Subject: Re: [Qemu-devel] [PATCH RFC] qemu-char: add logfile facility to socket backend Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Thu, Dec 17, 2015 at 01:49:32PM +0100, Paolo Bonzini wrote: > > > On 17/12/2015 13:02, Daniel P. Berrange wrote: > >>> > > > >>> > > $QEMU -chardev socket,host=localhost,port=9000,\ > >>> > > server=on,nowait,id-charserial0,\ > >>> > > logfile=/var/log/libvirt/qemu/test-serial0.log > >>> > > -device isa-serial,chardev=charserial0,id=serial0 > >> > > >> > Why for socket only? It would be very useful for stdio and especially vc. > > This is just an "RFC" so didn't want to spend the time to wire > > up all of them until I got positive feedback on the idea :-) > > Yes, I think it's fine. I guess one could do weird things with it such > as connecting it to a named pipe, but we shouldn't waste time preventing it. Great, I'll work on a properly complete patch for this then. > > If its acceptable, then I think it could make sense to just > > support optional "logfile" on every single backend, except "file" > > Yeah, I'd even wire it in qemu_chr_fe_write, and only prevent it for > "file" at option parsing time. Or just allow it for all of them. Yeah, doing it above the backend driver layer sounds like a nice simple approach to making it work universally. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|