From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>,
linux-kernel@vger.kernel.org,
Alexander Duyck <alexander.duyck@gmail.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] [PATCH] virtio_ring: use smp_store_mb
Date: Thu, 17 Dec 2015 16:43:53 +0200 [thread overview]
Message-ID: <20151217164343-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <20151217143910.GD6344@twins.programming.kicks-ass.net>
On Thu, Dec 17, 2015 at 03:39:10PM +0100, Peter Zijlstra wrote:
> On Thu, Dec 17, 2015 at 04:33:44PM +0200, Michael S. Tsirkin wrote:
> > On Thu, Dec 17, 2015 at 02:57:26PM +0100, Peter Zijlstra wrote:
> > >
> > > You could of course go fix that instead of mutilating things into
> > > sort-of functional state.
> >
> > Yes, we'd just need to touch all architectures, all for
> > the sake of UP which almost no one uses.
> > Basically, we need APIs that explicitly are
> > for talking to another kernel on a different CPU on
> > the same SMP system, and implemented identically
> > between CONFIG_SMP and !CONFIG_SMP on all architectures.
> >
> > Do you think this is something of general usefulness,
> > outside virtio?
>
> I'm not aware of any other case, but if there are more parts of virt
> that need this then I see no problem adding it.
>
> That is, virt in general is the only use-case that I can think of,
> because this really is an artifact of interfacing with an SMP host while
> running an UP kernel.
>
> But I'm really not familiar with virt, so I do not know if there's more
> sites outside of virtio that could use this.
>
> Touching all archs is a tad tedious, but its fairly straight forward.
Thanks, will take a stub at this.
next prev parent reply other threads:[~2015-12-17 14:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 10:32 [Qemu-devel] [PATCH] virtio_ring: use smp_store_mb Michael S. Tsirkin
2015-12-17 10:52 ` Peter Zijlstra
2015-12-17 13:16 ` Michael S. Tsirkin
2015-12-17 13:57 ` Peter Zijlstra
2015-12-17 14:33 ` Michael S. Tsirkin
2015-12-17 14:39 ` Peter Zijlstra
2015-12-17 14:43 ` Michael S. Tsirkin [this message]
2015-12-20 9:25 ` [Qemu-devel] new barrier type for paravirt (was Re: [PATCH] virtio_ring: use smp_store_mb) Michael S. Tsirkin
2015-12-20 17:07 ` [Qemu-devel] [Xen-devel] " Andrew Cooper
2015-12-20 19:59 ` Peter Zijlstra
2015-12-21 7:10 ` Michael S. Tsirkin
2015-12-21 7:22 ` [Qemu-devel] [PATCH RFC] smp_store_mb should use smp_mb Michael S. Tsirkin
2015-12-21 10:47 ` [Qemu-devel] [Xen-devel] new barrier type for paravirt (was Re: [PATCH] virtio_ring: use smp_store_mb) David Vrabel
2015-12-21 11:52 ` Michael S. Tsirkin
2015-12-21 14:50 ` Stefano Stabellini
2015-12-17 11:22 ` [Qemu-devel] [PATCH] virtio_ring: use smp_store_mb Peter Zijlstra
2015-12-17 13:26 ` Michael S. Tsirkin
2015-12-17 14:02 ` Peter Zijlstra
2015-12-17 14:34 ` Michael S. Tsirkin
2015-12-17 15:09 ` Peter Zijlstra
2015-12-17 15:52 ` Will Deacon
2015-12-17 19:21 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151217164343-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=qemu-devel@nongnu.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).