From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9biT-00019W-WF for qemu-devel@nongnu.org; Thu, 17 Dec 2015 11:47:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9biQ-00073k-By for qemu-devel@nongnu.org; Thu, 17 Dec 2015 11:47:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9biQ-00073g-55 for qemu-devel@nongnu.org; Thu, 17 Dec 2015 11:47:42 -0500 Date: Thu, 17 Dec 2015 16:47:38 +0000 From: "Daniel P. Berrange" Message-ID: <20151217164738.GJ16238@redhat.com> References: <1450366809-9800-1-git-send-email-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PULL v2 0/9] Introduce I/O channels framework Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers On Thu, Dec 17, 2015 at 04:40:47PM +0000, Peter Maydell wrote: > On 17 December 2015 at 15:40, Daniel P. Berrange wrote: > > The following changes since commit e5fbe28e5424d26fc2c25d0a7ecb927d3c80d5e8: > > > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20151217-1' into staging (2015-12-17 13:38:34 +0000) > > > > are available in the git repository at: > > > > git://github.com/berrange/qemu tags/pull-io-channel-base-2015-12-17-2 > > > > for you to fetch changes up to 65499bafaf39b75c9787ef39fffeb3ff9fe48424: > > > > io: add QIOChannelBuffer class (2015-12-17 15:28:33 +0000) > > > > ---------------------------------------------------------------- > > Merge I/O channels base classes > > > > ---------------------------------------------------------------- > > Daniel P. Berrange (9): > > io: add abstract QIOChannel classes > > io: add helper module for creating watches on FDs > > io: add QIOTask class for async operations > > io: add QIOChannelSocket class > > io: add QIOChannelFile class > > io: add QIOChannelTLS class > > io: add QIOChannelWebsock class > > io: add QIOChannelCommand class > > io: add QIOChannelBuffer class > > Still fails on OSX I'm afraid: > > /Users/pm215/src/qemu-for-merges/io/channel-buffer.c:211:5: warning: > implicit declaration of function 'g_source_set_name' is invalid > in C99 [-Wimplicit-function-declaration] > g_source_set_name(source, "QIOChannelBuffer"); > ^ > > /Users/pm215/src/qemu-for-merges/io/channel-file.c:164:11: warning: > implicit declaration of function 'lseek64' is invalid in C99 [-W > implicit-function-declaration] > ret = lseek64(fioc->fd, offset, whence); > ^ > > /Users/pm215/src/qemu-for-merges/io/channel-watch.c:155:5: warning: > implicit declaration of function 'g_source_set_name' is invalid in C99 > [-Wimplicit-function-declaration] > g_source_set_name(source, "QIOChannelFD"); > ^ > > /Users/pm215/src/qemu-for-merges/io/channel-websock.c:923:5: warning: > implicit declaration of function 'g_source_set_name' is invalid in C99 > [-Wimplicit-function-declaration] > g_source_set_name(source, "QIOChannelWebsock"); > ^ > CC iothread.o > > (and then the link fails because those functions aren't present). > > Glib's g_source_set_name was only introduced in 2.26, > and we have to support 2.22. Yep, that's no big deal. g_source_set_name is only there as a debugging aid, it has no functional benefit so I can remove these calls. > lseek64 doesn't exist on OSX. Ok. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|