From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9rTg-0002W3-Ep for qemu-devel@nongnu.org; Fri, 18 Dec 2015 04:37:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9rTd-0008Nx-PI for qemu-devel@nongnu.org; Fri, 18 Dec 2015 04:37:32 -0500 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:45805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9rTd-0008Ns-Gs for qemu-devel@nongnu.org; Fri, 18 Dec 2015 04:37:29 -0500 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 18 Dec 2015 09:37:27 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id F26B62190046 for ; Fri, 18 Dec 2015 09:37:16 +0000 (GMT) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tBI9bPGR59375658 for ; Fri, 18 Dec 2015 09:37:25 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tBI9bOZj016554 for ; Fri, 18 Dec 2015 02:37:25 -0700 Date: Fri, 18 Dec 2015 10:37:23 +0100 From: Cornelia Huck Message-ID: <20151218103723.13ee3db2.cornelia.huck@de.ibm.com> In-Reply-To: <1450423803-12839-2-git-send-email-shmulik.ladkani@ravellosystems.com> References: <1450423803-12839-1-git-send-email-shmulik.ladkani@ravellosystems.com> <1450423803-12839-2-git-send-email-shmulik.ladkani@ravellosystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] compat: Introduce HW_COMPAT_2_5 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shmulik Ladkani Cc: Jason Wang , idan.brown@ravellosystems.com, qemu-devel@nongnu.org, Dmitry Fleytman , Paolo Bonzini , David Gibson On Fri, 18 Dec 2015 09:30:02 +0200 Shmulik Ladkani wrote: > Introduce the place-holder for 2.5 back-compat properties, and the > accompanying PC_COMPAT_2_5, CCW_COMPAT_2_5, SPAPR_COMPAT_2_5. > > Signed-off-by: Shmulik Ladkani > --- > hw/i386/pc_piix.c | 1 + > hw/i386/pc_q35.c | 1 + > hw/ppc/spapr.c | 9 +++++++++ > hw/s390x/s390-virtio-ccw.c | 9 +++++++++ > include/hw/compat.h | 3 +++ > include/hw/i386/pc.h | 4 ++++ > 6 files changed, 27 insertions(+) > > diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c > index 5a52ff2..3d79654 100644 > --- a/hw/s390x/s390-virtio-ccw.c > +++ b/hw/s390x/s390-virtio-ccw.c > @@ -235,7 +235,11 @@ static const TypeInfo ccw_machine_info = { > }, > }; > > +#define CCW_COMPAT_2_5 \ > + HW_COMPAT_2_5 > + > #define CCW_COMPAT_2_4 \ > + CCW_COMPAT_2_5 \ > HW_COMPAT_2_4 \ > {\ > .driver = TYPE_S390_SKEYS,\ > @@ -296,10 +300,15 @@ static const TypeInfo ccw_machine_2_4_info = { > static void ccw_machine_2_5_class_init(ObjectClass *oc, void *data) > { > MachineClass *mc = MACHINE_CLASS(oc); > + static GlobalProperty compat_props[] = { > + CCW_COMPAT_2_5 > + { /* end of list */ } > + }; > > mc->alias = "s390-ccw-virtio"; > mc->desc = "VirtIO-ccw based S390 machine v2.5"; > mc->is_default = 1; > + mc->compat_props = compat_props; > } > > static const TypeInfo ccw_machine_2_5_info = { s390x part: Acked-by: Cornelia Huck