From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38829)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1a9vBr-000218-Lx
	for qemu-devel@nongnu.org; Fri, 18 Dec 2015 08:35:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1a9vBm-00004t-KS
	for qemu-devel@nongnu.org; Fri, 18 Dec 2015 08:35:23 -0500
Received: from mx1.redhat.com ([209.132.183.28]:57125)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1a9vBm-0008WV-Et
	for qemu-devel@nongnu.org; Fri, 18 Dec 2015 08:35:18 -0500
Date: Fri, 18 Dec 2015 13:35:13 +0000
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20151218133513.GD2459@work-vm>
References: <1450438575-21613-1-git-send-email-berrange@redhat.com>
	<5673FDB0.6040900@redhat.com> <20151218130555.GB7228@redhat.com>
	<56740537.9010106@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56740537.9010106@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] scripts: provide a script for checking
	glib symbol usage
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>

* Paolo Bonzini (pbonzini@redhat.com) wrote:
> 
> 
> On 18/12/2015 14:05, Daniel P. Berrange wrote:
> > > > +
> > > > +cs-glib-syms:
> > > > +	@perl scripts/glib-syms.pl $(GLIB_SYMS_LIST) $(C_CODE_FILES)
> > > 
> > > 
> > > Does this need to be included, or could it be a separate Makefile
> > > invoked with e.g. make -f scripts/Makefile.style?
> > 
> > Any particular reason to favour that over include ? I did it this
> > way because QEMU in general seems to be biased towards includes
> > and not recursive make
> 
> That would not be recursive make, but rather a completely separate
> Makefile to be manually invoked with -f.

Hmm but wouldn't this Makefile also be a good place for small-fast
style check scripts that could be included in  make check  ?

Dave

> 
> Paolo
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK