Re: [Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage

["Daniel P. Berrange" <berrange@redhat.com>]

On Fri, Dec 18, 2015 at 01:35:13PM +0000, Dr. David Alan Gilbert wrote:
> * Paolo Bonzini (pbonzini@redhat.com) wrote:
> > 
> > 
> > On 18/12/2015 14:05, Daniel P. Berrange wrote:
> > > > > +
> > > > > +cs-glib-syms:
> > > > > +	@perl scripts/glib-syms.pl $(GLIB_SYMS_LIST) $(C_CODE_FILES)
> > > > 
> > > > 
> > > > Does this need to be included, or could it be a separate Makefile
> > > > invoked with e.g. make -f scripts/Makefile.style?
> > > 
> > > Any particular reason to favour that over include ? I did it this
> > > way because QEMU in general seems to be biased towards includes
> > > and not recursive make
> > 
> > That would not be recursive make, but rather a completely separate
> > Makefile to be manually invoked with -f.
> 
> Hmm but wouldn't this Makefile also be a good place for small-fast
> style check scripts that could be included in  make check  ?

Nothing about "make check" is fast, so we could probably just wire it
all into make check by default, as qtest & the block tests take some
considerable time to run. IOW people who want speed will be running
"make check-unit" or individual tests already.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|