From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39177) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9vEH-0003CK-PB for qemu-devel@nongnu.org; Fri, 18 Dec 2015 08:37:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9vEE-0000Rg-3B for qemu-devel@nongnu.org; Fri, 18 Dec 2015 08:37:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33935) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9vED-0000Rb-UA for qemu-devel@nongnu.org; Fri, 18 Dec 2015 08:37:50 -0500 Date: Fri, 18 Dec 2015 13:37:45 +0000 From: "Daniel P. Berrange" Message-ID: <20151218133745.GC7228@redhat.com> References: <1450438575-21613-1-git-send-email-berrange@redhat.com> <5673FDB0.6040900@redhat.com> <20151218130555.GB7228@redhat.com> <56740537.9010106@redhat.com> <20151218133513.GD2459@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20151218133513.GD2459@work-vm> Subject: Re: [Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: Peter Maydell , Paolo Bonzini , qemu-devel@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau On Fri, Dec 18, 2015 at 01:35:13PM +0000, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonzini@redhat.com) wrote: > > > > > > On 18/12/2015 14:05, Daniel P. Berrange wrote: > > > > > + > > > > > +cs-glib-syms: > > > > > + @perl scripts/glib-syms.pl $(GLIB_SYMS_LIST) $(C_CODE_FILES) > > > > > > > > > > > > Does this need to be included, or could it be a separate Makefile > > > > invoked with e.g. make -f scripts/Makefile.style? > > > > > > Any particular reason to favour that over include ? I did it this > > > way because QEMU in general seems to be biased towards includes > > > and not recursive make > > > > That would not be recursive make, but rather a completely separate > > Makefile to be manually invoked with -f. > > Hmm but wouldn't this Makefile also be a good place for small-fast > style check scripts that could be included in make check ? Nothing about "make check" is fast, so we could probably just wire it all into make check by default, as qtest & the block tests take some considerable time to run. IOW people who want speed will be running "make check-unit" or individual tests already. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|