* [Qemu-devel] [PATCH] hw/ppc/spapr_rtc: Remove bad class_size value
@ 2015-12-18 9:06 Thomas Huth
2015-12-21 0:47 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2015-12-18 9:06 UTC (permalink / raw)
To: qemu-ppc, David Gibson; +Cc: Alexander Graf, qemu-devel
class_size = sizeof(XICSStateClass) does not make much sense
in the RTC code and likely was just a copy-n-paste error.
Let's simply remove it.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/ppc/spapr_rtc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/ppc/spapr_rtc.c b/hw/ppc/spapr_rtc.c
index 34b27db..b591a8e 100644
--- a/hw/ppc/spapr_rtc.c
+++ b/hw/ppc/spapr_rtc.c
@@ -200,7 +200,6 @@ static const TypeInfo spapr_rtc_info = {
.name = TYPE_SPAPR_RTC,
.parent = TYPE_SYS_BUS_DEVICE,
.instance_size = sizeof(sPAPRRTCState),
- .class_size = sizeof(XICSStateClass),
.class_init = spapr_rtc_class_init,
};
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/ppc/spapr_rtc: Remove bad class_size value
2015-12-18 9:06 [Qemu-devel] [PATCH] hw/ppc/spapr_rtc: Remove bad class_size value Thomas Huth
@ 2015-12-21 0:47 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2015-12-21 0:47 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-ppc, Alexander Graf, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]
On Fri, Dec 18, 2015 at 10:06:14AM +0100, Thomas Huth wrote:
> class_size = sizeof(XICSStateClass) does not make much sense
> in the RTC code and likely was just a copy-n-paste error.
> Let's simply remove it.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Oops, that's an embarrasing error. Fix applied to ppc-for-2.5 and ppc-for-2.6
> ---
> hw/ppc/spapr_rtc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/ppc/spapr_rtc.c b/hw/ppc/spapr_rtc.c
> index 34b27db..b591a8e 100644
> --- a/hw/ppc/spapr_rtc.c
> +++ b/hw/ppc/spapr_rtc.c
> @@ -200,7 +200,6 @@ static const TypeInfo spapr_rtc_info = {
> .name = TYPE_SPAPR_RTC,
> .parent = TYPE_SYS_BUS_DEVICE,
> .instance_size = sizeof(sPAPRRTCState),
> - .class_size = sizeof(XICSStateClass),
> .class_init = spapr_rtc_class_init,
> };
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-21 0:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-18 9:06 [Qemu-devel] [PATCH] hw/ppc/spapr_rtc: Remove bad class_size value Thomas Huth
2015-12-21 0:47 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).